- Wine-GitLab - list.winehq.org

Re: [PATCH v6 0/2] MR1746: setupapi: Use MultiByteToUnicode and UnicodeToMultiByte instead of reimplementing them.
by Zebediah Figura (＠zfigura) April 4, 2023

April 4, 2023

Zebediah Figura (@zfigura) commented about dlls/setupapi/devinst.c: > { > if (procnameW) > { > - procname = strdupWtoA(procnameW + 1); > + procname = UnicodeToMultiByte(procnameW + 1, CP_ACP); > coinst_proc = (void *)GetProcAddress(module, procname); > - heap_free(procname); > + MyFree(procname); It's hard for me to feel like this is an improvement, when we are now adding an extra parameter to every call, and also using some undocumented Windows functions that, to the reader, might have some obscure different semantics. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1746#note_28895

1 0

[PATCH v2 0/1] MR2575: ws2_32/tests: Adjust test results without host IPv6 support.
by Rémi Bernon April 4, 2023

April 4, 2023

As seen when running the tests in Docker without IPv6 support configured, see for instance https://test.winehq.org/data/64cca153292833151d1adeb185252ca57e2d1625/linux…. -- v2: ws2_32/tests: Adjust test results without host IPv6 support. https://gitlab.winehq.org/wine/wine/-/merge_requests/2575

2 3

[PATCH v2 0/6] MR2577: d3dcompiler: Use the vkd3d-shader DXBC API.
by Henri Verbeet (＠hverbeet) April 4, 2023

April 4, 2023

The main advantage is that this way we're getting valid DXBC checksums for DXBC blobs generated by d3dcompiler. See also https://bugs.winehq.org/show_bug.cgi?id=54464. -- v2: d3dcompiler: Use vkd3d_shader_parse_dxbc() in d3dcompiler_shader_reflection_init(). d3dcompiler: Use vkd3d_shader_parse_dxbc() in d3dcompiler_strip_shader(). d3dcompiler: Use vkd3d_shader_parse_dxbc() in d3dcompiler_get_blob_part(). d3dcompiler: Use vkd3d_shader_serialize_dxbc() in d3dcompiler_strip_shader(). d3dcompiler: Use vkd3d_shader_serialize_dxbc() in d3dcompiler_get_blob_part(). d3dcompiler: Store DXBC sections as vkd3d_shader_dxbc_section_desc structures. https://gitlab.winehq.org/wine/wine/-/merge_requests/2577

3 8

[PATCH 0/1] MR144: vkd3d-shader: Align the start offset instead of the size in bytecode_put_bytes().
by Henri Verbeet (＠hverbeet) April 4, 2023

April 4, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/144

2 1

[PATCH v6 0/7] MR2568: win32u: Support setting the current mode using gdi_device_manager.
by Alexandros Frantzis (＠afrantzis) April 4, 2023

April 4, 2023

Update the gdi_device_manager API to enable drivers to set the current mode (along with the registry mode if not already set) in UpdateDisplayDevices. This changes also allows us to remove the driver code that manually changes the registry settings. -- v6: wineandroid.drv: Set the current mode using gdi_device_manager. winemac.drv: Set the current mode using gdi_device_manager. https://gitlab.winehq.org/wine/wine/-/merge_requests/2568

3 10

[PATCH 0/1] MR2583: winedbg: Don't crash when no search path has been set.
by eric pouech (＠epo) April 4, 2023

April 4, 2023

Note: it's anyway wrong to search source files inside modules' path (a proper fix will require revisiting source file handling). This fix will actually be sufficient when running wine from within its build tree. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2583

2 1

[PATCH 0/1] MR2582: kernel32/tests: Workaround broken behavior in Win7 Pro64.
by eric pouech (＠epo) April 4, 2023

April 4, 2023

Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2582

2 1

[PATCH v5 0/7] MR2568: win32u: Support setting the current mode using gdi_device_manager.
by Alexandros Frantzis (＠afrantzis) April 4, 2023

April 4, 2023

Update the gdi_device_manager API to enable drivers to set the current mode (along with the registry mode if not already set) in UpdateDisplayDevices. This changes also allows us to remove the driver code that manually changes the registry settings. -- v5: wineandroid.drv: Set the current mode using gdi_device_manager. winemac.drv: Set the current mode using gdi_device_manager. winemac.drv: Extract function to get the current mode. winewayland.drv: Set the current mode using gdi_device_manager. winex11.drv: Set the current mode using gdi_device_manager. winex11.drv: Extract function to check devmode equality. win32u: Support setting the current mode using gdi_device_manager. https://gitlab.winehq.org/wine/wine/-/merge_requests/2568

2 10

[PATCH 0/1] MR2579: kernel32/debugger: Fix a failing test (on Wine).
by eric pouech (＠epo) April 4, 2023

April 4, 2023

The failing test was garbled by remaining debug events from previous test. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2579

2 1

[PATCH v4 0/7] MR2568: win32u: Support setting the current mode using gdi_device_manager.
by Alexandros Frantzis (＠afrantzis) April 4, 2023

April 4, 2023

Update the gdi_device_manager API to enable drivers to set the current mode (along with the registry mode if not already set) in UpdateDisplayDevices. This changes also allows us to remove the driver code that manually changes the registry settings. -- v4: wineandroid.drv: Set the current mode using gdi_device_manager. winemac.drv: Set the current mode using gdi_device_manager. winemac.drv: Extract function to get the current mode. winewayland.drv: Set the current mode using gdi_device_manager. winex11.drv: Set the current mode using gdi_device_manager. win32u: Support setting the current mode using gdi_device_manager. debug.h: Add debugstr_devmodew() helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/2568

4 19