- Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/3] MR2410: gitlab: Make FVWM respect position hints. - approved
by Alexandre Julliard (＠julliard) March 15, 2023

March 15, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2410

1 0

Re: [PATCH v16 0/10] MR1445: kernelbase: Some refactoring of the open_key() and create_key() functions. - approved
by Alexandre Julliard (＠julliard) March 15, 2023

March 15, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1445

1 0

Re: [PATCH v2 0/5] MR2407: imm32: Fix ImmGetIMEFileName(A|W) and ImmGetDescription(A|W). - approved
by Alexandre Julliard (＠julliard) March 15, 2023

March 15, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2407

1 0

Re: [PATCH v4 0/1] MR118: vkd3d-shader: Fix a few typos in the comments. - approved
by Alexandre Julliard (＠julliard) March 15, 2023

March 15, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/118

1 0

[PATCH 0/7] MR124: vkd3d-shader/hlsl: Introduce hlsl_ir_index, part 1/2.
by Francisco Casas (＠fcasas) March 15, 2023

March 15, 2023

This node type is intended for use during parse-time. While we parse an indexing expression such as `a[3]`, we don't know if it will end up as part of an expression (in which case it must be folded into a load) or it is for the lhs of a store (in which case it must be folded into the store's deref). This node type is used to represent these accesses and no longer rely on building an `hlsl_ir_load` for each array index or struct record access. `hlsl_ir_index` chains are lowered into derefs when (and if) they are used to specify the lhs of an assignment. All `hlsl_ir_index`es are lowered into `hlsl_ir_load`s with a compilation pass. The changes introduced in these series allow to solve the problem with the return variable of function calls presented in !93, and to properly support assignment to matrix indexes, which is something we are not doing correctly. Further patches (in my [index node](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/index_node) branch) add support for indexing non-load expressions, such as `(a + b)[1]` and allowing to represent resource loads through `hlsl_ir_index`, so that `hlsl_ir_resource_store`s don't have to rely on `hlsl_ir_resource_load`s. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/124

3 10

[PATCH v3 0/1] MR118: vkd3d-shader: Fix a few typos in the comments.
by Nikolay Sivov (＠nsivov) March 15, 2023

March 15, 2023

-- v3: vkd3d-shader: Fix a few typos in the comments. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/118

3 3

[PATCH 0/3] MR2410: gitlab: Make FVWM respect position hints.
by Zhiyi Zhang (＠zhiyi) March 15, 2023

March 15, 2023

FVWM doesn't respect PPosition hints by default and tries to tile a window according to its rules. This might break tests that require a window at a specific position. For example, when setting the caption bar height to anything other than 18, some user32 tests start to fail. They succeeded previously just because the caption bar and border height on FVWM totals to 18, which is happens to be the same value used by Wine by default. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2410

2 3

[PATCH 0/4] MR2408: winex11: Detect Xkb layouts and create HKL registry keys.
by Rémi Bernon March 15, 2023

March 15, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2408

2 5

[PATCH 0/5] MR2407: imm32: Fix ImmGetIMEFileName(A|W) and ImmGetDescription(A|W).
by Rémi Bernon March 15, 2023

March 15, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2407

1 5

Re: [PATCH v2 0/1] MR2403: crypt32: Add some CertGetNameStringW fallback cases
by Hans Leidekker (＠hans) March 15, 2023

March 15, 2023

Hans Leidekker (@hans) commented about dlls/crypt32/str.c: > - oid = szOID_RSA_emailAddr; > - nameAttr = CertFindRDNAttr(oid, nameInfo); > + if (oid) > + nameAttr = CertFindRDNAttr(oid, nameInfo); > + else > + { > + static const LPCSTR attributeOIDs[] = > + { > + szOID_RSA_emailAddr, szOID_COMMON_NAME, > + szOID_ORGANIZATIONAL_UNIT_NAME, szOID_ORGANIZATION_NAME > + }; > + DWORD i; > + > + for (i = 0; !nameAttr && i < ARRAY_SIZE(attributeOIDs); i++) > + nameAttr = CertFindRDNAttr(attributeOIDs[i], nameInfo); > + } Thanks for the patch. Could you add a test to crypt32/tests/str.c? At least one fallback case would be good to have. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2403#note_26961

1 0