- Wine-GitLab - list.winehq.org

Re: [PATCH v6 0/2] MR2114: kernelbase: Fix performance of beatmap search in osu! Stable. - approved
by Alexandre Julliard (＠julliard) Feb. 23, 2023

Feb. 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2114

1 0

Re: [PATCH v10 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics::IsSupportedAsync(). - approved
by Alexandre Julliard (＠julliard) Feb. 23, 2023

Feb. 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

1 0

Re: [PATCH v3 0/4] MR2267: msvcr80: Fix _(w)dupenv_s behavior with missing environment variable. - approved
by Alexandre Julliard (＠julliard) Feb. 23, 2023

Feb. 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2267

1 0

Re: [PATCH v2 0/1] MR2264: ntdll: Avoid shrinking large heap block to small block. - approved
by Alexandre Julliard (＠julliard) Feb. 23, 2023

Feb. 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2264

1 0

Re: [PATCH v5 0/5] MR2010: wined3d: More Vulkan feature checks. - approved
by Alexandre Julliard (＠julliard) Feb. 23, 2023

Feb. 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2010

1 0

[PATCH v4 0/1] MR2263: evr: Fix crash when clear input type for the mixer
by Tingzhong Luo (＠tzluo) Feb. 23, 2023

Feb. 23, 2023

In the implementation of [`evr_disconnect()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/evr.c#L325-333), it will try to clear types of mixer by pass null to `IMFTransform_SetInputType()`: ```c static void evr_disconnect(struct strmbase_renderer *iface) { struct evr *filter = impl_from_strmbase_renderer(iface); if (filter->mixer) IMFTransform_SetInputType(filter->mixer, 0, NULL, 0); evr_set_input_type(filter, NULL); evr_release_services(filter); } ``` This null ptr (`media_type`) will be pass to [`video_mixer_collect_output_types()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c#L869) and cause a [crash](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c…: ```c static HRESULT WINAPI video_mixer_transform_SetInputType(IMFTransform *iface, DWORD id, IMFMediaType *media_type, DWORD flags) { ... if (!mixer->device_manager) hr = MF_E_NOT_INITIALIZED; else { if (SUCCEEDED(hr = video_mixer_get_processor_service(mixer, &service))) { if (SUCCEEDED(hr = video_mixer_init_dxva_videodesc(media_type, &video_desc))) ... ``` In this patch, `video_mixer_transform_SetInputType()` will only clear types when got a NULL `media_type` and return `S_OK`. -- v4: evr: Fix crash when clear input type for the mixer https://gitlab.winehq.org/wine/wine/-/merge_requests/2263

3 2

Re: [PATCH v4 0/11] MR103: DXBC handling API - approved
by Alexandre Julliard (＠julliard) Feb. 23, 2023

Feb. 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/103

1 0

Re: [PATCH v3 0/1] MR105: vkd3d: Remove a double space in a comment. - approved
by Alexandre Julliard (＠julliard) Feb. 23, 2023

Feb. 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/105

1 0

Re: [PATCH v7 0/3] MR101: vkd3d-shader/hlsl: Improvements to builtin typenames handling. - approved
by Alexandre Julliard (＠julliard) Feb. 23, 2023

Feb. 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/101

1 0

Re: [PATCH v13 0/6] MR1445: kernelbase: Some refactoring of the open_key() and create_key() functions.
by Alexandre Julliard (＠julliard) Feb. 23, 2023

Feb. 23, 2023

Alexandre Julliard (@julliard) commented about dlls/kernelbase/registry.c: > > static BOOL is_wow6432node( const UNICODE_STRING *name ) > { > - return (name->Length == 11 * sizeof(WCHAR) && !wcsnicmp( name->Buffer, L"Wow6432Node", 11 )); > + return (name->Length >= 11 * sizeof(WCHAR) && !wcsnicmp( name->Buffer, L"Wow6432Node", 11 )); This doesn't look right, we need an exact match. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1445#note_25333

1 0