- Wine-GitLab - list.winehq.org

[PATCH v2 0/4] MR2267: msvcr80: Fix _(w)dupenv_s behavior with missing environment variable.
by Rémi Bernon Feb. 23, 2023

Feb. 23, 2023

-- v2: msvcrt: Fix _wdupenv_s behavior with missing env var. msvcrt: Fix _dupenv_s behavior with missing env var. msvcr80/tests: Test _wdupenv_s outcome with missing env var. msvcr80/tests: Test _dupenv_s outcome with missing env var. https://gitlab.winehq.org/wine/wine/-/merge_requests/2267

2 6

Re: [PATCH v6 0/3] MR101: vkd3d-shader/hlsl: Improvements to builtin typenames handling. - approved
by Giovanni Mascellani (＠giomasce) Feb. 23, 2023

Feb. 23, 2023

This merge request was approved by Giovanni Mascellani. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/101

1 0

[PATCH v3 0/1] MR2263: evr: Fix crash when clear input type for the mixer
by Tingzhong Luo (＠tzluo) Feb. 23, 2023

Feb. 23, 2023

In the implementation of [`evr_disconnect()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/evr.c#L325-333), it will try to clear types of mixer by pass null to `IMFTransform_SetInputType()`: ```c static void evr_disconnect(struct strmbase_renderer *iface) { struct evr *filter = impl_from_strmbase_renderer(iface); if (filter->mixer) IMFTransform_SetInputType(filter->mixer, 0, NULL, 0); evr_set_input_type(filter, NULL); evr_release_services(filter); } ``` This null ptr (`media_type`) will be pass to [`video_mixer_collect_output_types()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c#L869) and cause a [crash](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c…: ```c static HRESULT WINAPI video_mixer_transform_SetInputType(IMFTransform *iface, DWORD id, IMFMediaType *media_type, DWORD flags) { ... if (!mixer->device_manager) hr = MF_E_NOT_INITIALIZED; else { if (SUCCEEDED(hr = video_mixer_get_processor_service(mixer, &service))) { if (SUCCEEDED(hr = video_mixer_init_dxva_videodesc(media_type, &video_desc))) ... ``` In this patch, `video_mixer_transform_SetInputType()` will only clear types when got a NULL `media_type` and return `S_OK`. -- v3: evr: Fix crash when clear input type for the mixer https://gitlab.winehq.org/wine/wine/-/merge_requests/2263

3 4

[PATCH v2 0/11] MR103: DXBC handling API
by Henri Verbeet (＠hverbeet) Feb. 23, 2023

Feb. 23, 2023

Public API for parsing and serialising DXBC blobs. -- v2: vkd3d-shader/dxbc: Introduce API for serialising DXBC blobs. vkd3d-shader/dxbc: Introduce API for parsing DXBC blobs. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/103

4 26

[PATCH 0/4] MR2267: msvcr80: Fix _(w)dupenv_s behavior with missing environment variable.
by Rémi Bernon Feb. 23, 2023

Feb. 23, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2267

1 4

[PATCH v2 0/1] MR2263: evr: Fix crash when clear input type for the mixer
by Tingzhong Luo (＠tzluo) Feb. 23, 2023

Feb. 23, 2023

In the implementation of [`evr_disconnect()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/evr.c#L325-333), it will try to clear types of mixer by pass null to `IMFTransform_SetInputType()`: ```c static void evr_disconnect(struct strmbase_renderer *iface) { struct evr *filter = impl_from_strmbase_renderer(iface); if (filter->mixer) IMFTransform_SetInputType(filter->mixer, 0, NULL, 0); evr_set_input_type(filter, NULL); evr_release_services(filter); } ``` This null ptr (`media_type`) will be pass to [`video_mixer_collect_output_types()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c#L869) and cause a [crash](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c…: ```c static HRESULT WINAPI video_mixer_transform_SetInputType(IMFTransform *iface, DWORD id, IMFMediaType *media_type, DWORD flags) { ... if (!mixer->device_manager) hr = MF_E_NOT_INITIALIZED; else { if (SUCCEEDED(hr = video_mixer_get_processor_service(mixer, &service))) { if (SUCCEEDED(hr = video_mixer_init_dxva_videodesc(media_type, &video_desc))) ... ``` In this patch, `video_mixer_transform_SetInputType()` will only clear types when got a NULL `media_type` and return `S_OK`. -- v2: evr: Fix crash when clear input type for the mixer https://gitlab.winehq.org/wine/wine/-/merge_requests/2263

3 3

[PATCH v2 0/5] MR2258: winegstreamer: Support WMV DMO decoder.
by Ziqing Hui (＠zhui) Feb. 23, 2023

Feb. 23, 2023

-- v2: winegstreamer: Implement ProcessInput and ProcessOutput for WMV decoder DMO. winegstreamer: Create wg_transform for WMV decoder. winegstreamer: Better handle framerate. winegstreamer: Add format field to wmv wg_format. winegstreamer: Implement wg_transform data read/write for DMO. https://gitlab.winehq.org/wine/wine/-/merge_requests/2258

3 9

[PATCH 0/1] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) Feb. 23, 2023

Feb. 23, 2023

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

3 2

[PATCH 0/1] MR2265: include: Allow overriding LANGID in module VERSIONINFO.
by Rémi Bernon Feb. 23, 2023

Feb. 23, 2023

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/2221, this is required by `ImmInstallIME` and .ime modules. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2265

1 1

[PATCH 0/1] MR2264: ntdll: Avoid shrinking large heap block to small block.
by Rémi Bernon Feb. 23, 2023

Feb. 23, 2023

Even though this is a waste of memory it seems to trip on some UAF with some games. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54475 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2264

1 1