- Wine-GitLab - list.winehq.org

[PATCH v5 0/2] MR821: Replace obsolete RtlUniform tests that no longer work (currently skipped) since Windows Vista; update RtlUniform impl.
by Jinoh Kang (＠iamahuman) Jan. 29, 2023

Jan. 29, 2023

Today, test_RtlUniform() skips almost all of its tests on Windows Vista or later. The skipped tests only succeed in Windows XP, and fail on Windows Vista or later. This is because RtlUniform()'s behavior has changed, presumably due to a bug fix shipped in Windows Vista. It appears that RtlUniform, a linear congruential generator, could overflow before computing the modulo in WindoWs XP. This is no longer the case in Windows Vista or later. Meanwhile, we no longer support Windows XP behavior and thus do not test for it regularly; therefore, the tests are obsolete as of 2023. Remove obsolete tests that no longer work with any of the Windows versions actively tested by WineHQ (as of 2023), and replace them with updated tests that works in the Windows versions from Vista up to 10. Also, fix Wine's RtlUniform() to match the new behavior accordingly. -- v5: ntdll: Fix integer overflow in RtlUniform. https://gitlab.winehq.org/wine/wine/-/merge_requests/821

2 2

[PATCH v4 0/2] MR821: Replace obsolete RtlUniform tests that no longer work (currently skipped) since Windows Vista; update RtlUniform impl.
by Jinoh Kang (＠iamahuman) Jan. 29, 2023

Jan. 29, 2023

Today, test_RtlUniform() skips almost all of its tests on Windows Vista or later. The skipped tests only succeed in Windows XP, and fail on Windows Vista or later. This is because RtlUniform()'s behavior has changed, presumably due to a bug fix shipped in Windows Vista. It appears that RtlUniform, a linear congruential generator, could overflow before computing the modulo in WindoWs XP. This is no longer the case in Windows Vista or later. Meanwhile, we no longer support Windows XP behavior and thus do not test for it regularly; therefore, the tests are obsolete as of 2023. Remove obsolete tests that no longer work with any of the Windows versions actively tested by WineHQ (as of 2023), and replace them with updated tests that works in the Windows versions from Vista up to 10. Also, fix Wine's RtlUniform() to match the new behavior accordingly. -- v4: ntdll: Fix integer overflow in RtlUniform. ntdll/tests: Update test_RtlUniform to match Windows Vista or later. https://gitlab.winehq.org/wine/wine/-/merge_requests/821

2 3

[PATCH 0/1] MR2050: include: Remove __WINE_MALLOC from functions that shouldn't have it.
by Alex Henrie (＠alexhenrie) Jan. 29, 2023

Jan. 29, 2023

According to the GCC documentation,[1] `__attribute__((malloc))` may not be used on functions that return memory that contains one or more valid pointers. [1] https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2050

3 4

[PATCH 0/1] MR2054: ntoskrnl.exe: Add stub for IoQueryFileDosDeviceName.
by Etaash Mathamsetty (＠etaash.mathamsetty) Jan. 29, 2023

Jan. 29, 2023

battleye seems to be calling this function -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2054

2 1

[PATCH v2 0/1] MR2033: ntoskrnl: Add ExGetPreviousMode and test.
by Alex Henrie (＠alexhenrie) Jan. 28, 2023

Jan. 28, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54378 -- v2: ntoskrnl: Add ExGetPreviousMode and test. https://gitlab.winehq.org/wine/wine/-/merge_requests/2033

2 2

[PATCH 0/1] MR1749: mshtml: Add head, title and body elements to about:blank.
by Santino Mazza (＠tati1454) Jan. 28, 2023

Jan. 28, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1749

4 6

[PATCH v4 0/9] MR1628: Draft: ntdll: Implement Low Fragmentation Heap.
by Rémi Bernon Jan. 28, 2023

Jan. 28, 2023

Not completely sure if it's worth having for 8.0, but opening this to share the target I'm trying to reach. -- v4: ntdll: Implement Low Fragmentation Heap. ntdll: Introduce per-thread free lists for heap blocks. ntdll: Introduce a new BLOCK_FLAG_SPLIT heap block flag. ntdll: Introduce a new subheap thread affinity field. ntdll: Introduce a new heap block_init_used helper. ntdll: Introduce a new heap free_list_init helper. ntdll: Count allocations and automatically enable LFH. ntdll: Implement HeapCompatibilityInformation. ntdll: Fix HeapWalk with empty uncommitted consecutive subheaps. https://gitlab.winehq.org/wine/wine/-/merge_requests/1628

2 11

[PATCH v3 0/2] MR2051: include/msvcrt: Add noreturn attribute to _assert.
by Jinoh Kang (＠iamahuman) Jan. 28, 2023

Jan. 28, 2023

This informs the compiler that no code will ever run after an assertion failure (unless NDEBUG is defined), which increases accuracy of compiler warnings and static analyses. -- v3: include/msvcrt: Add noreturn attribute to _assert. include/msvcrt: Add noreturn attribute to RtlRaiseStatus. https://gitlab.winehq.org/wine/wine/-/merge_requests/2051

2 4

[PATCH 0/1] MR2033: ntoskrnl: Add ExGetPreviousMode stub.
by Alex Henrie (＠alexhenrie) Jan. 28, 2023

Jan. 28, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54378 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2033

5 7

[PATCH v3 0/8] MR1628: Draft: ntdll: Implement Low Fragmentation Heap.
by Rémi Bernon Jan. 28, 2023

Jan. 28, 2023

Not completely sure if it's worth having for 8.0, but opening this to share the target I'm trying to reach. -- v3: ntdll: Implement Low Fragmentation Heap. ntdll: Introduce per-thread free lists for heap blocks. ntdll: Introduce a new BLOCK_FLAG_SPLIT heap block flag. ntdll: Introduce a new subheap thread affinity field. ntdll: Introduce a new heap block_init_used helper. ntdll: Introduce a new heap free_list_init helper. ntdll: Count allocations and automatically enable LFH. ntdll: Implement HeapCompatibilityInformation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1628

3 11