- Wine-GitLab - list.winehq.org

[PATCH v6 0/2] MR1578: ntdll: TlsIndex should not actually contain tls indices
by Evan Tang (＠etang-cw) Dec. 14, 2022

Dec. 14, 2022

> (The TlsIndex field in the LDR_DATA_TABLE_ENTRY structure appears to be unused except as a flag that the module has TLS (being always set to -1), at least as far back as Windows XP. It is worth mentioning that the WINE implementation of implicit TLS incorrectly uses TlsIndex as the real module TLS index, so it may be unreliable to assume that it is always -1 if you care about working on WINE.) > > \- http://www.nynaeve.net/?p=186 and the "links to that article but still doesn't work in wine" award goes to... [the D runtime](https://github.com/dlang/dmd/blob/6bf60ea0eb174631ede0074a77d3898d…! (Admittedly, there aren't too many ways to do what they're trying to do.) With this, the D runtime will now work in Wine, even if in a dll loaded into an exe with no tls (which gets it the tls index 0) The changes to the debugger are a bit icky, a possible alternative is to find some other easily-debugger-accessible place to stuff the tls index. -- v6: ntdll: TlsIndex should not actually contain tls indices winedbg: Don't expect TlsIndex to contain tls indices https://gitlab.winehq.org/wine/wine/-/merge_requests/1578

3 4

Re: [PATCH v7 0/2] MR1686: include/msvcrt: Add __WINE_(ALLOC_SIZE|DEALLOC|MALLOC) attributes to _strdup, _wcsdup, _aligned_malloc
by Alex Henrie (＠alexhenrie) Dec. 14, 2022

Dec. 14, 2022

Alex Henrie (@alexhenrie) commented about include/msvcrt/corecrt_malloc.h: > _ACRTIMP void __cdecl free(void*); > _ACRTIMP void* __cdecl malloc(size_t); > _ACRTIMP void* __cdecl realloc(void*,size_t); > _ACRTIMP void* __cdecl _recalloc(void*,size_t,size_t); You can annotate _recalloc now too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1686#note_19603

1 0

Re: [PATCH v2 0/5] MR1750: wined3d: More Vulkan feature checks. - approved
by Alexandre Julliard (＠julliard) Dec. 13, 2022

Dec. 13, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1750

1 0

Re: [PATCH v2 0/6] MR1802: server: Inherit socket fields in accept_socket(). - approved
by Alexandre Julliard (＠julliard) Dec. 13, 2022

Dec. 13, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1802

1 0

Re: [PATCH v3 0/2] MR1803: ntoskrnl/tests: Ignore CONFIGFLAG_FINISH_INSTALL on the child device. - approved
by Alexandre Julliard (＠julliard) Dec. 13, 2022

Dec. 13, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1803

1 0

Re: [PATCH v2 0/4] MR1808: winemac: Fix remaining printf format warnings. - approved
by Alexandre Julliard (＠julliard) Dec. 13, 2022

Dec. 13, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1808

1 0

Re: [PATCH v2 0/1] MR1776: include: Add _recalloc. - approved
by Alexandre Julliard (＠julliard) Dec. 13, 2022

Dec. 13, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1776

1 0

Re: [PATCH v2 0/1] MR1804: win32u: Downgrade the NtOpenFile ERR to a WARN in add_device(). - approved
by Alexandre Julliard (＠julliard) Dec. 13, 2022

Dec. 13, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1804

1 0

[PATCH v2 0/5] MR53: vkd3d-shader/hlsl: transpose(), smoothstep(), and properly convert args of element-wise intrinsics.
by Francisco Casas (＠fcasas) Dec. 13, 2022

Dec. 13, 2022

This patch series includes an implementation of the long-pending `transpose` intrinsic and the `smoothstep` intrinsic. While implementing `smoothstep` I realized that some intrinsics have different rules for the allowed data types than expressions: - Vectors and matrices at the same time are not allowed, regardless of their dimensions. Even if they have the same number of components. - Any combination of matrices is always allowed, even those when no matrix fits inside another, e.g.: `float2x3` is compatible with `float3x2`, resulting in `float2x2`. The common data type is the min on each dimension. This is the case for `max`, `pow`, `ldexp`, `clamp` and `smoothstep`; which suggest that it is the case for all intrinsics where the operation is applied element-wise. So this was corrected. A minor fix in `pow`'s type conversion is also included. -- v2: vkd3d-shader/hlsl: Use add_unary_arithmetic_expr() in intrinsic_pow(). vkd3d-shader/hlsl: Convert elementwise intrinsics args to the proper common type. tests: Test for common type conversion for element-wise intrinsics. vkd3d-shader/hlsl: Support smoothstep() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/53

4 13

Re: [PATCH v2 0/8] MR1684: d3d10/effect: Further improvements to expressions support.
by Matteo Bruni (＠Mystral) Dec. 13, 2022

Dec. 13, 2022

Matteo Bruni (@Mystral) commented about dlls/d3d10/effect.c: > + unsigned int i; > + > + *retval = 0.0f; > + for (i = 0; i < instr->comp_count; ++i) > + *retval += args[0][instr->scalar ? 0 : i] * args[1][i]; > +} > + > +static void pres_dotswiz(float **args, unsigned int n, const struct preshader_instr *instr) > +{ > + float *retval = args[n]; > + unsigned int i; > + > + *retval = 0.0f; > + for (i = 0; i < n; ++i) > + *retval += *args[i] * *args[i + n / 2]; > +} This doesn't look right to me either. In any case, I think we want a test for this right away. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1684#note_19578

1 0