- Wine-GitLab - list.winehq.org

[PATCH v5 0/10] MR1074: Draft: ntdll: Improve Valgrind and GDB integration.
by Rémi Bernon Dec. 12, 2022

Dec. 12, 2022

Valgrind support requires a fork, which I've published to https://gitlab.winehq.org/rbernon/valgrind. The fork implements loading DWARF debug info from PE files, instead of the old and broken upstream PDB support. I've tried to upstream these changes a long time ago but didn't receive any feedback. I think we could maybe consider keeping a fork, which I'm happy to maintain, as the changes aren't too large. We may want to investigate adding 32-on-64 support, which may require a bit more changes (to VEX specifically, because its amd64 guest doesn't support segment register manipulation). The changes here are not all related to Valgrind, and I'll create separate MR for those which may make sense independently from Valgrind / GDB. Also included is a suppression file to silent some annoying false positives, many of which are coming from the cross-stack accesses during syscalls, which are confusing Valgrind's stack heuristics. One can try this out with something like: `WINELOADERNOEXEC=1 valgrind --suppressions=tools/valgrind.supp wine64/loader/wine64 wine64/programs/winecfg/winecfg.exe` -- v5: ntdll: Avoid writing to invalid memory in i386 unix dispatcher. ntdll: Set %rsp before args in x86_64 call_user_mode_callback. ntdll: Fix incorrect i386 call_user_mode_callback CFI. ntdll: Fix valgrind notifications from ntdll.so. ntdll: Import valgrind headers for PE side ntdll. ntdll: Allocate a truly separate stack for the kernel stack. ntdll: Maintain a PE module link map and expose it to GDB. ntdll: Pass a UNICODE_STRING to load_builtin and virtual_map_image. loader: Expose a shadow copy of ld.so link map to GDB. ntdll: Add .cfi_signal_frame to __wine_syscall_dispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/1074

1 11

[PATCH v4 0/54] MR1074: Draft: ntdll: Improve Valgrind and GDB integration.
by Rémi Bernon Dec. 12, 2022

Dec. 12, 2022

Valgrind support requires a fork, which I've published to https://gitlab.winehq.org/rbernon/valgrind. The fork implements loading DWARF debug info from PE files, instead of the old and broken upstream PDB support. I've tried to upstream these changes a long time ago but didn't receive any feedback. I think we could maybe consider keeping a fork, which I'm happy to maintain, as the changes aren't too large. We may want to investigate adding 32-on-64 support, which may require a bit more changes (to VEX specifically, because its amd64 guest doesn't support segment register manipulation). The changes here are not all related to Valgrind, and I'll create separate MR for those which may make sense independently from Valgrind / GDB. Also included is a suppression file to silent some annoying false positives, many of which are coming from the cross-stack accesses during syscalls, which are confusing Valgrind's stack heuristics. One can try this out with something like: `WINELOADERNOEXEC=1 valgrind --suppressions=tools/valgrind.supp wine64/loader/wine64 wine64/programs/winecfg/winecfg.exe` -- v4: ntdll: Avoid writing to invalid memory in i386 unix dispatcher. ntdll: Set %rsp before args in x86_64 call_user_mode_callback. ntdll: Fix incorrect i386 call_user_mode_callback CFI. ntdll: Fix valgrind notifications from ntdll.so. ntdll: Import valgrind headers for PE side ntdll. ntdll: Allocate a truly separate stack for the kernel stack. ntdll: Maintain a PE module link map and expose it to GDB. ntdll: Pass a UNICODE_STRING to load_builtin and virtual_map_image. loader: Expose a shadow copy of ld.so link map to GDB. ntdll: Add .cfi_signal_frame to __wine_syscall_dispatcher. configure: Quiet recheck and Werror. d3dx9_36/tests: Fix an array size warning. ntdll: Initialize unix_pid and unix_tid. rpcrt4: Fix partial allocation warnings. winegstreamer: Use QWORD instead of uint64_t for length. shell32: Avoid undefined behavior with partially allocated structs. user32: Avoid undefined behavior with partially allocated structs. jscript: Use flexible array member to avoid a warning. devenum: Avoid undefined behavior with uninitialized value. webservices: Explicitly cast WS_XML_READER_ENCODING_TYPE enum. msvcp60: Use an explicit type to avoid a warning. krnl386.exe16: Avoid undefined behavior. krnl386.exe16: Avoid passing NULL to lstrcpyA. winedbg: Avoid undefined behavior with printing NULL string. winex11: Avoid undefined behavior with uninitialized value. scrobj: Avoid depending on uninitialized hres value. gdiplus: Initialize ofs. ole32/tests: Avoid fixed pointer usage. ntdll: Avoid use of uninitialized ch. kernelbase: Avoid returning uninitialized HMODULE. comctl32: Always initialize dtFlags. mciseq: Print data only when successfully read. dwrite/tests: Silent a todo_wine identation warning. kernelbase/tests: Initialize input buffer to silent a warning. ntoskrnl.exe: Make USD pointers volatile to silent a warning. user.exe16: Initialize RECT to silent a warning. shlwapi/tests: Initialize input buffer to silent a warning. ddraw: Use designated initializer to avoid implicit enum cast. d3d8: Use designated initializer to avoid implicit enum cast. d3d11: Avoid implicit enum value cast. d2d1: Avoid implicit D2D1_FACTORY_TYPE enum cast. d2d1: Remove unnecessary cast. include: Support running all tests at once with --all. gitlab: Avoid unnecessary winetest re-link on incremental builds. configure.ac: Check for git presence and use $(GIT) variable. configure.ac: Use ; rather than && to chain variable and comparison. Revert "gitlab: Run lengthy tests in a separate job." Revert "gitlab: Run short tests on 32-bit too." WIP: build: Prefer local gitlab runner. gitlab: Run lengthy tests in a separate job. gitlab: Add a job to run some tests as 64-bit. gitlab: Run related tests on every commit. gitlab: Run some tests with nulldrv driver. WIP: build: Add a github actions workflow. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/1074

1 0

[PATCH 0/2] MR1789: mf/tests: Test GetOutputType for WMV decoder.
by Ziqing Hui (＠zhui) Dec. 12, 2022

Dec. 12, 2022

The 2 patches came for https://gitlab.winehq.org/wine/wine/-/merge_requests/1707 It's code freeze time. So I split the test patches from MR 1707 to make tests upstreamed. They are totally identical to what they look like before. Nothing changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1789

3 3

[PATCH 0/1] MR1785: msi: Fix memory leak on realloc failure in search_directory (cppcheck).
by Alex Henrie (＠alexhenrie) Dec. 12, 2022

Dec. 12, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1785

3 2

[PATCH 0/1] MR1784: msi: Fix memory leak on realloc failure in msi_get_window_text (cppcheck).
by Alex Henrie (＠alexhenrie) Dec. 12, 2022

Dec. 12, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1784

3 2

[PATCH 0/1] MR1783: msi: Fix memory leak on realloc failure in create_diff_row_query (cppcheck).
by Alex Henrie (＠alexhenrie) Dec. 12, 2022

Dec. 12, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1783

3 2

[PATCH 0/1] MR1790: winspool: Improve the grammar of a comment in get_servername_from_name.
by Alex Henrie (＠alexhenrie) Dec. 12, 2022

Dec. 12, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1790

3 2

[PATCH 0/1] MR1768: winspool: Fix test failures on Windows 11.
by Piotr Caban (＠piotr) Dec. 12, 2022

Dec. 12, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1768

3 2

[PATCH v3 0/3] MR1707: winegstreamer: Implement IMediaObject_GetOutputType for WMV decoder.
by Ziqing Hui (＠zhui) Dec. 12, 2022

Dec. 12, 2022

In this patch set, GetOutputType() currently fails for NV11 and the following RGB types because MFCalculateImageSize() fails for them. I'll fix MFCalculateImageSize() for them recently (but not in this patch set). -- v3: winegstreamer: Implement GetOutputType for WMV decoder. mf/tests: Test info headers returned by GetOutputType for WMV decoder. mf/tests: Test GetOutputType for WMV decoder. https://gitlab.winehq.org/wine/wine/-/merge_requests/1707

4 8

[PATCH 0/1] MR1787: shell32: Handle memory allocation failure in parse_dde_command (cppcheck).
by Alex Henrie (＠alexhenrie) Dec. 12, 2022

Dec. 12, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1787

2 1