wine-bugs October 2009

wine-bugs@winehq.org

1 participants
6166 discussions

[Bug 7150] Implement Arabic shaping
by wine-bugs＠winehq.org 26 Oct '09

26 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=7150 --- Comment #15 from Alexander Scott-Johns <alexander.scott.johns+winebug(a)googlemail.com> 2009-10-26 14:25:54 --- (In reply to comment #13) > > Muayyad, wine developers don't grab patches from bugzilla, see > my beloved brother, as you know I send patches to several project (anaconda, > publican, gnome-xsl, packagekit, pulseaudio, fedora, ...) and they all > accept my patches through bugzilla > > could you please please continue with them if I were too busy. I think the maintainer has Emacs hooked up to the wine-patches mailing list, and doesn't want to change his workflow... > > * Please keep the spacing of your code consistent with the rest of the > > file(4 space indentation, spaces around binary operators, etc). > > my patches only add lines so put the code I added into a file then call a > indent tool over it with the right arguments winehq wants, that's not a big > deal :-) Wine is very careful about maintaining authorship info; changing other people's patches and submitting them isn't liked that much. > BTW: what are those argument (so that I would do this step if I send > patches to winehq in the future) > [snip] > > * Can you please use slightly more descriptive variable names than p, c, > > cn, ch, jx, jcn, jpc, j, i and ix? > > it's a complicated optimized algorithm, in which variables could be reused, > but since those variables are locally used within my function only they > don't worth commenting or being long (as in kernel coding style) Yes, but this isn't the kernel... Short variable names are good, but it should be obvious what they mean. > but don't worry here are the meanings [snip] > > > * Is it possible to write conformance tests for this? (If so, please > > include some, as the patch will be much more likely to get in.) > > I'm a native speaker and it works, we ship the patched version in our distro > (ojuba linux) and we had offered several patched version in parallel to all > wine updates in fedora 11 > Conformance tests are also useful as regression tests, in case someone else breaks your code later on. Also remember that Wine doesn't try to do things _correctly_, but to do them the same way Windows does. > we have not received bug reports related to this patch [snip] > shaping will be skipped. > > > * You may find it easier to manage and generate your patches with Git. > this patch only add lines that are independent of the code, I'm certain > that can be applied cleanly as-is without any extra effort. > > please try it, and inform me if it did not. I'm sure it does apply cleanly. It's just that using a CMS (like git) would make it much easier to rebase (update) from WineHQ when the maintainer applies patches. PS: I can't speak/read Arabic, nor do I have any Arabic Windows programs, so I can't really test the patch or comment on how it works (just how it looks). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 7150] Implement Arabic shaping
by wine-bugs＠winehq.org 26 Oct '09

26 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=7150 --- Comment #14 from alsadi <alsadi(a)ojuba.org> 2009-10-26 12:17:48 --- > articles written by me Shachar! why haven't you implemented your docs ? according to me the proper BiDi handling is :-) - Bidi level calculations - Line breaking - Reodering - Shaping my code is very optimized, so if you just want to move things for optimization purpose just forget it, you won't get a better performance, that would be near impossible. why did I made it the last step of BiDi process ? because shaping changes the characters which would interfere the Reodering process for example a Reodering routine might know that U+639 is RTL but it may/may not know that U+FECC is RTL too (many Reodering routines in many project don't handle this case, I don't know about wine) notes: U+0639 ARABIC LETTER AIN U+FECC ARABIC LETTER AIN MEDIAL FORM and since I don't want to change any other function, I made it after Reodering. the case where Shaping should be done before reodering is when the char length of U+0639 is less that shaped U+FECC but this is not the case in wine (UTF-16) so the positions calculated by your reordering are granted to be valid as my function is 1-1. the right thing to do is to use HarfBuzz which is in its way as a standalone library. http://fedoraproject.org/wiki/Features/Harfbuzz but since this is a decision to be made in winehq, this is the only thing I can do. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 7150] Implement Arabic shaping
by wine-bugs＠winehq.org 26 Oct '09

26 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=7150 alsadi <alsadi(a)ojuba.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alsadi(a)ojuba.org --- Comment #13 from alsadi <alsadi(a)ojuba.org> 2009-10-26 11:57:46 --- > Muayyad, wine developers don't grab patches from bugzilla, see my beloved brother, as you know I send patches to several project (anaconda, publican, gnome-xsl, packagekit, pulseaudio, fedora, ...) and they all accept my patches through bugzilla could you please please continue with them if I were too busy. > * Please keep the spacing of your code consistent with the rest of the file (4 space indentation, spaces around binary operators, etc). my patches only add lines so put the code I added into a file then call a indent tool over it with the right arguments winehq wants, that's not a big deal :-) BTW: what are those argument (so that I would do this step if I send patches to winehq in the future) > * You don't need to include your email address in the code itself (as the Wine Git repository tracks authorship information). feel free to remove it (I grant you the permission, in case if your lawyer is worried) * Can you please use slightly more descriptive variable names than p, c, cn, ch, jx, jcn, jpc, j, i and ix? it's a complicated optimized algorithm, in which variables could be reused, but since those variables are locally used within my function only they don't worth commenting or being long (as in kernel coding style) but don't worry here are the meanings p-> point that moves through the text being processed c-> current char jcn-> should we join current with next? jpc-> should we join previous with current? j-> point to the some element in joins array jx -> an element in ArabicShapingData joining data * Is it possible to write conformance tests for this? (If so, please include some, as the patch will be much more likely to get in.) I'm a native speaker and it works, we ship the patched version in our distro ( ojuba linux) and we had offered several patched version in parallel to all wine updates in fedora 11 we have not received bug reports related to this patch (multi line editing is due to bidi and it's independent of this patch, small fonts a config issue, and wine renders chars that supposed to be invisible like U+2xyz) regarding non-Arabic text, it can be proved that it will not be affected by this patch because of if no chars in the range of ArabicShapingData, skip will be equal to True and the second shaping loop which will do the actual shaping will be skipped. > * You may find it easier to manage and generate your patches with Git. this patch only add lines that are independent of the code, I'm certain that can be applied cleanly as-is without any extra effort. please try it, and inform me if it did not. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 8847] Halo - All non-static objects are invisible
by wine-bugs＠winehq.org 26 Oct '09

26 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=8847 Justin Soulia <rockinup1231(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rockinup1231(a)gmail.com --- Comment #12 from Justin Soulia <rockinup1231(a)gmail.com> 2009-10-26 10:37:14 --- With Wine 1.1.32, playing with the -useff flag enabled (aka in fixed function mode without specular or vertex shaders of any kind) causes this bug to resurface. This also occurs using older hardware that can only operate in fixed function mode (GeForce4, Radeon 7000, etc). Ironically, the game seems slower in fixed function mode too, where it should actually be much faster without shaders. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 20446] New: Network Mapped Drive
by wine-bugs＠winehq.org 26 Oct '09

26 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=20446 Summary: Network Mapped Drive Product: Wine Version: 1.1.30 Platform: PC URL: http://www.recover.eu OS/Version: Linux Status: UNCONFIRMED Severity: blocker Priority: P1 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: info(a)recover.eu Hi, A big congratulation to the staff who make wine like this! but I have a bug (very very important for me) To understand, here is the configuration of the network concerned: n:\ (\\my_server\home) i:\ (\\my_server\print_drive) where all the doc generated by progs will be copied to be printed/archived,...) r:\ (\\myserver\template) where all the file containing doc to be generated with some parameters (EG: name,adresse,..) x:\ (\\my_server\bin) where all the progs.exe to be used in the office can be found (Yes, it is possible!) The x:\myprog.exe takes a file (eg: r:\service_offer.txt) then go to Oracle to get (name,adresses, etc..) and generate a file to be printed saved in (i:\docs\tobeprinted\) (a print server take the relay because lots of docs are generated) My company employes actually 15 employees and 20 independants and we want to tell "goodbye" to microsoft and use wine but whitout this, it is simply NOT possible... It is the ONLY bug in wine that prevent us to move ... Can you do something? Thank you for your response... PS: a smb mounting in linux with a ln -s in /dosdevices/ don't work: myprog.exe can't open files even if in wine cmd "i:" is viewed and seems to work... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 3

[Bug 20448] New: Touhou 7 and 10 segfault at startup with Intel drivers >= 2.7, 64-bit
by wine-bugs＠winehq.org 26 Oct '09

26 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=20448 Summary: Touhou 7 and 10 segfault at startup with Intel drivers >= 2.7, 64-bit Product: Wine Version: 1.1.32 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-d3d AssignedTo: wine-bugs(a)winehq.org ReportedBy: hyperair(a)gmail.com Created an attachment (id=24300) --> (http://bugs.winehq.org/attachment.cgi?id=24300) Adds a NULL pointer check before dumping FBO attachments Touhou 7 and 10 segfault at startup with Intel drivers >= 2.7, 64-bit. The reason for this is context_check_fbo_status() being passed a NULL pointer in context->current_fbo by content_apply_fbo_state(). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 16

[Bug 7150] Implement Arabic shaping
by wine-bugs＠winehq.org 26 Oct '09

26 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=7150 --- Comment #12 from Shachar Shemesh <shachar(a)shemesh.biz> 2009-10-26 03:00:44 --- (In reply to comment #9) > Created an attachment (id=23239) --> (http://bugs.winehq.org/attachment.cgi?id=23239) [details] > faster as it skips shaping if there is nothing to shape I don't think what this comment should prevent this patch from going in, but better handle these things earlier than later. The proper place for shaping to take place is before reordering, not after it. The proper BiDi handling is: - Bidi level calculations - Shaping - Line breaking - Reordering I know that, with the current implementation, level calculation and reordering are done in one step, and that therefor it is a little impossible to implement the steps as described, but this is, non the less, where we should aspire to be. More details at http://www.lingnu.com/en/programming.html (plug warning - articles written by me). Shachar -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 17700] New: Microsoft Word 2007 Hangs when scrolling a file with to many pages
by wine-bugs＠winehq.org 26 Oct '09

26 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=17700 Summary: Microsoft Word 2007 Hangs when scrolling a file with to many pages Product: Wine Version: 1.1.16 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: jaimerave(a)gmail.com Created an attachment (id=19899) --> (http://bugs.winehq.org/attachment.cgi?id=19899) Example document Try to open the attached document and scroll to the last page. Microsoft Word should hang and show an error message. This is in Ubuntu 8.10 with wine 1.1.16. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 15

[Bug 20468] New: Xfire crashes upon clicking anywhere in its window
by wine-bugs＠winehq.org 26 Oct '09

26 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=20468 Summary: Xfire crashes upon clicking anywhere in its window Product: Wine Version: 1.1.32 Platform: PC URL: http://www.xfire.com/download OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: sanders3cg(a)yahoo.com Created an attachment (id=24352) --> (http://bugs.winehq.org/attachment.cgi?id=24352) Full text from the Xfire Crash Report Xfire crashes upon clicking anywhere in its window and triggers an Xfire Crash Report. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 8

[Bug 20470] New: Neuz.exe
by wine-bugs＠winehq.org 26 Oct '09

26 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=20470 Summary: Neuz.exe Product: Wine Version: unspecified Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: th3gui14rm4n(a)aim.com Wouldn't let the game start yet everything else worked. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-bugs October 2009