https://bugs.winehq.org/show_bug.cgi?id=5137
Bruno Jesus <00cpxxx(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Fixed by SHA1| |d28c40da3bc685241363370f4b4
| |86bd975396afc
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #18 from Bruno Jesus <00cpxxx(a)gmail.com> ---
Fixed by:
http://source.winehq.org/git/wine.git/commitdiff/d28c40da3bc685241363370f4b…
--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=6955
JHaleIT <jhaleit(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jhaleit(a)gmail.com
--- Comment #144 from JHaleIT <jhaleit(a)gmail.com> ---
I can confirm that this bug exist in the latest version of Wine in WineBottler
for Phantasy Star Universe.
--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=5908
Anastasius Focht <focht(a)gmx.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Fixed by SHA1| |497b67dbf623e8aacb2eaaaa326
| |a5782eb3c06d8
CC| |focht(a)gmx.net
Component|shell32 |wintrust
Hardware|Other |x86
Version|unspecified |0.9.18.
OS|other |Linux
--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37127
Bug ID: 37127
Summary: PVS-Studio Error: Unreliable tests
Product: Wine
Version: 1.7.22
Hardware: x86-64
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: -unknown
Assignee: wine-bugs(a)winehq.org
Reporter: lukebenes(a)hotmail.com
PVS-Studio identifies Unreliable tests. Some of the modules' folders contain
the test folder with source files for tests. Debug information is printed
through the 'ok' macro. Here are a few suspicious fragments:
V501 There are identical sub-expressions to the left and to the right of the
'==' operator: ddsd3.lpSurface == ddsd3.lpSurface dsurface.c 272
...
ok(ddsd3.lpSurface == ddsd3.lpSurface, //<==
"lpSurface from GetSurfaceDesc(%p) differs\
from the one returned by Lock(%p)\n",
ddsd3.lpSurface, ddsd2.lpSurface); //<==
...
It very much looks like a typo. I suspect this code should compare the same
variables that are printed.
V502 Perhaps the '?:' operator works in a different way than it was expected.
The '?:' operator has a lower priority than the '==' operator. url.c 767
...
ok(size == no_callback ? 512 : 13, "size=%d\n", size);
...
The precedence of the "==" operator is higher than that of '?:', so the size
variable is not compared to the values 512 and 13. The expression is always
true as it evaluates either to 512 or 13, which means this check doesn't check
anything.
Other similar fragments:
V502 Perhaps the '?:' operator works in a different way than it was
expected. The '?:' operator has a lower priority than the '==' operator.
string.c 1086
V502 Perhaps the '?:' operator works in a different way than it was
expected. The '?:' operator has a lower priority than the '==' operator.
string.c 1111
V502 Perhaps the '?:' operator works in a different way than it was
expected. The '?:' operator has a lower priority than the '==' operator.
reader.c 761
V502 Perhaps the '?:' operator works in a different way than it was
expected. The '?:' operator has a lower priority than the '==' operator.
protocol.c 2928
V502 Perhaps the '?:' operator works in a different way than it was
expected. The '?:' operator has a lower priority than the '==' operator. dde.c
1594
V502 Perhaps the '?:' operator works in a different way than it was
expected. The '?:' operator has a lower priority than the '==' operator.
reader.c 761
details on the V501 error here: http://www.viva64.com/en/d/0090/
details on the V502 error here: http://www.viva64.com/en/d/0091/
--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37126
Bug ID: 37126
Summary: PVS-Studio Error: Printing the result of identical
functions
Product: Wine
Version: 1.7.22
Hardware: x86-64
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: -unknown
Assignee: wine-bugs(a)winehq.org
Reporter: lukebenes(a)hotmail.com
PVS-Studio identifies Printing the result of identical functions Error,V681.
The language standard does not define an order in which the 'tlb_read_byte'
functions will be called during evaluation of arguments. tlb.c 650
...
printf("\\%2.2x \\%2.2x\n", tlb_read_byte(), tlb_read_byte());
...
According to the C++ language standard, the sequence of computing a function's
actual arguments is not defined. Which function will be called first depends on
the compiler, compilation parameters, etc.
details on the V681 error here: http://www.viva64.com/en/d/0315/
--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37123
Bug ID: 37123
Summary: PVS-Studio Error: Double type conversion
Product: Wine
Version: 1.7.22
Hardware: x86-64
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: -unknown
Assignee: wine-bugs(a)winehq.org
Reporter: lukebenes(a)hotmail.com
PVS-Studio identifies a Double type conversion Error.
The *void pointer is cast to other types twice: first to char*, then to DWORD*,
after which an offset is added. Either the expression lacks parentheses or the
code is excessive. Whether or not there is an error here depends on how much
the programmer wanted to increment the pointer.
V650 Type casting operation is utilized 2 times in succession. Next, the '+'
operation is executed. Probably meant: (T1)((T2)a + b). typelib.c 9147
...
struct WMSFT_SegContents arraydesc_seg;
typedef struct tagWMSFT_SegContents {
DWORD len;
void *data;
} WMSFT_SegContents;
...
DWORD offs = file->arraydesc_seg.len;
DWORD *encoded;
encoded = (DWORD*)((char*)file->arraydesc_seg.data) + offs;//<==
Another similar issue:
V650 Type casting operation is utilized 2 times in succession. Next, the '+'
operation is executed. Probably meant: (T1)((T2)a + b). protocol.c 194
INT WINAPI
EnumProtocolsW(LPINT protocols, LPVOID buffer, LPDWORD buflen)
{
...
unsigned int string_offset;
...
pi[i].lpProtocol = (WCHAR*)(char*)buffer + string_offset;//<==
...
}
details on the V650 error here: http://www.viva64.com/en/d/0269/
--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37120
Bug ID: 37120
Summary: PVS-Studio Error: Equivalent branches of if operator
Product: Wine
Version: 1.7.22
Hardware: x86-64
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: -unknown
Assignee: wine-bugs(a)winehq.org
Reporter: lukebenes(a)hotmail.com
Equivalent branches of if operator
V523 The 'then' statement is equivalent to the 'else' statement. filedlg.c 3302
if(pDIStruct->itemID == liInfos->uSelectedItem)
{
ilItemImage = (HIMAGELIST) SHGetFileInfoW (
(LPCWSTR) tmpFolder->pidlItem, 0, &sfi, sizeof (sfi),
shgfi_flags );
}
else
{
ilItemImage = (HIMAGELIST) SHGetFileInfoW (
(LPCWSTR) tmpFolder->pidlItem, 0, &sfi, sizeof (sfi),
shgfi_flags );
}
This code is either excessive or contains a typo.
V523 The 'then' statement is equivalent to the 'else' statement. genres.c 1130
...
if(win32)
{
put_word(res, 0); /* Reserved */
/* FIXME: The ResType in the NEWHEADER structure should
* contain 14 according to the MS win32 doc. This is
* not the case with the BRC compiler and I really doubt
* the latter. Putting one here is compliant to win16 spec,
* but who knows the true value?
*/
put_word(res, 1); /* ResType */
put_word(res, icog->nicon);
for(ico = icog->iconlist; ico; ico = ico->next)
{
...
}
}
else /* win16 */
{
put_word(res, 0); /* Reserved */
put_word(res, 1); /* ResType */
put_word(res, icog->nicon);
for(ico = icog->iconlist; ico; ico = ico->next)
{
...
}
}
...
One of the repeating branches is commented. Perhaps this is an incomplete
fragment, not an error, but I decided to point it out anyway.
details on the V523 error here: http://www.viva64.com/en/d/0112/
--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37119
Bug ID: 37119
Summary: PVS-Studio Error: Cascade of conditional operators
Product: Wine
Version: 1.7.22
Hardware: x86
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: -unknown
Assignee: wine-bugs(a)winehq.org
Reporter: lukebenes(a)hotmail.com
V517 The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is
a probability of logical error presence. Check lines: 1754, 1765. msi.c 1754
if (!strcmpW( szProperty, INSTALLPROPERTY_LOCALPACKAGEW )) //<==
{
...
}
else if (!strcmpW( szProperty, INSTALLPROPERTY_INSTALLDATEW ))
{
...
}
else
if (!strcmpW( szProperty, INSTALLPROPERTY_LOCALPACKAGEW )) //<==
{
...
}
else if (!strcmpW( szProperty, INSTALLPROPERTY_UNINSTALLABLEW ) ||
!strcmpW( szProperty, INSTALLPROPERTY_PATCHSTATEW ) ||
!strcmpW( szProperty, INSTALLPROPERTY_DISPLAYNAMEW ) ||
!strcmpW( szProperty, INSTALLPROPERTY_MOREINFOURLW ))
{
...
}
else
{
...
}
If identical conditions are checked in a cascade of conditional operators,
those conditions never get control. Perhaps there is a typo in the constant
INSTALLPROPERTY_* passed to this fragment.
details on the V517 error here: http://www.viva64.com/en/d/0106/
--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=36800
Bug ID: 36800
Summary: XMP failed to start, services.exe has crashed
Product: Wine
Version: 1.7.20
Hardware: x86
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: -unknown
Assignee: wine-bugs(a)winehq.org
Reporter: penghao(a)linuxdeepin.com
download from:
http://xmp.down.sandai.net/kankan/XMPSetup_4.9.16.2203-www.exe
after install, start XMP from:
~/.wine/drive_c/Program Files/Thunder Network/Xmp/Program/
with:
wine XMP.exe
then the services.exe report crashed.
--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.