wine-bugs November 2022

wine-bugs@winehq.org

1 participants
3243 discussions

[Bug 53821] New: winbase.h: ReOpenFile declaration missing (and not available in any other header)
by WineHQ Bugzilla 27 Mar '23

27 Mar '23

https://bugs.winehq.org/show_bug.cgi?id=53821 Bug ID: 53821 Summary: winbase.h: ReOpenFile declaration missing (and not available in any other header) Product: Wine Version: 7.19 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: kernel32 Assignee: wine-bugs(a)winehq.org Reporter: contact(a)ivanchev.net Distribution: --- A declaration for ReOpenFile should be imported with winbase.h (https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-reop…) but is currently missing. In fact, no header in Wine declares that function. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 53706] New: NtDeviceIoControlFile() is quite slow when called with and invalid handle
by WineHQ Bugzilla 27 Mar '23

27 Mar '23

https://bugs.winehq.org/show_bug.cgi?id=53706 Bug ID: 53706 Summary: NtDeviceIoControlFile() is quite slow when called with and invalid handle Product: Wine Version: 7.17 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: ntdll Assignee: wine-bugs(a)winehq.org Reporter: metalcaedes(a)gmail.com Distribution: --- Created attachment 73130 --> https://bugs.winehq.org/attachment.cgi?id=73130 Call DeviceIoControl() with an invalid handle a lot and measure how long it takes I'm running some nonpublic proprietary application that I don't have the source code for in Wine (I attached a simple testprogram though). I noticed severe performance problems (compared with native Windows) and profiling it in perf (is there a better way?) showed a lot of useless memory addresses and also NtDeviceIoControlFile(). I figured out that the application calls DeviceIoControl() *a lot*, and after hooking that function and replacing it with a stub that basically just returns FALSE the application's performance was a lot better (good enough for my purposes). Being the curious type, I added some logging to my stub and realized that the handle that gets passed is 0xFFFFFFFF (INVALID_HANDLE_VALUE) - even on Windows! Specifically, I saw: hDevice: 0xFFFFFFFF code: 0x80010021 inBufSize: 4 outBufSize: 4 overlapped: 0x0 Reimplementing DeviceIoControl() (based on Wine Source) in my (former) stub and adding some time measurements showed that in this specific case (calling it with an invalid handle) the called NtDeviceIoControlFile() often takes around 4 microseconds on Wine (sometimes even over 20!) while it only takes around 0.5 microseconds on Windows 10 (even though that PC is a bit slower). So it takes 8-40 times as long in Wine. Looking into Wine's NtDeviceIoControlFile() implementation, this is probably the case because it calls into wineserver, via `server_ioctl_file()`. So I *think* that this could be relatively easily fixed by checking if the handle is INVALID_HANDLE_VALUE first thing in NtDeviceIoControlFile(), and if that's the case call `SetLastError( ERROR_INVALID_HANDLE );` and `return FALSE;` (Windows returns FALSE and sets that error code). I'm not 100% sure about this though, because I don't know if there are any cases of calling `NtDeviceIoControlFile()` where INVALID_HANDLE_VALUE is OK - if there are, the early-out-check would probably have to take the `code` argument into account (as far as I can tell it specifies the operation that NtDeviceIoControlFile() executes). I attached a simple test program that just calls DeviceIoControl() a lot (with the parameters I've seen in the real program I have issues with) and measures how long that takes. On my Windows machine (i7-4771, Win10) one call takes about 0.48-0.5 microseconds. On my Linux machine (Ryzen 5950X, Kernel 5.15, wine 7.17) one call takes about 4 microseconds on average, though many calls took longer. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 53614] New: KeyPassXC does not open
by WineHQ Bugzilla 27 Mar '23

27 Mar '23

https://bugs.winehq.org/show_bug.cgi?id=53614 Bug ID: 53614 Summary: KeyPassXC does not open Product: Wine Version: 7.16 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: blocker Priority: P2 Component: msvcp Assignee: wine-bugs(a)winehq.org Reporter: dstwine(a)mailinator.com Distribution: --- Created attachment 73012 --> https://bugs.winehq.org/attachment.cgi?id=73012 Log from console As in the title. Impossible to run KeyPassXC on Ubuntu 20.04 and Winehq 7.16 (but also 7.0 stable). A console is returned with error 5 because windbg cannot attach to obtain a backtrace. I attached the log in the console that concern the process related to KeyPassXC. Best regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 53455] New: shell32:recyclebin - test_query_recyclebin() gets unexpected recyclebin size in Wine
by WineHQ Bugzilla 27 Mar '23

27 Mar '23

https://bugs.winehq.org/show_bug.cgi?id=53455 Bug ID: 53455 Summary: shell32:recyclebin - test_query_recyclebin() gets unexpected recyclebin size in Wine Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: shell32 Assignee: wine-bugs(a)winehq.org Reporter: fgouget(a)codeweavers.com Distribution: --- shell32:recyclebin - test_query_recyclebin() gets unexpected recyclebin size: recyclebin.c:79: Test failed: Expected recycle bin to have 0x22 bytes recyclebin.c:80: Test failed: Expected recycle bin to have 0x1 items https://test.winehq.org/data/patterns.html#shell32:recyclebin The expected size in bytes can also be 0x20 or 0x21 which can cause false positives. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 53003] New: XM6 TypeG: some MIDI note-on messages aren't sent to MIDI devices (MIDI running status isn't supported in the MIDI mapper)
by WineHQ Bugzilla 27 Mar '23

27 Mar '23

https://bugs.winehq.org/show_bug.cgi?id=53003 Bug ID: 53003 Summary: XM6 TypeG: some MIDI note-on messages aren't sent to MIDI devices (MIDI running status isn't supported in the MIDI mapper) Product: Wine Version: 7.8 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: winmm&mci Assignee: wine-bugs(a)winehq.org Reporter: sagawa.aki+winebugs(a)gmail.com Distribution: Ubuntu Created attachment 72371 --> https://bugs.winehq.org/attachment.cgi?id=72371 minimal reproducible example XM6 TypeG[1] is a SHARP X68000 Emulator. When I use STed2[2] inside XM6 TypeG, some MIDI note-on messages aren't sent to MIDI devices (e.g. Timidity++). @honda_ken, an original reporter on Twitter, tweeted XM6 TypeG sounds strange on Wine. He also informed me that Wine outputs the following message on his console: 0338:fixme:midi:modData ooch 3c 0338:fixme:midi:modData ooch 403e 0338:fixme:midi:modData ooch 3e 0338:fixme:midi:modData ooch 4040 0338:fixme:midi:modData ooch 40 0338:fixme:midi:modData ooch 4041 0338:fixme:midi:modData ooch 41 0338:fixme:midi:modData ooch 4043 0338:fixme:midi:modData ooch 43 I setup XM6 TypeG environment on my PC and I can reproduce the issue. Preparing the environment is a bit difficult, I wrote a minimal reproducible example (shortmsg.c). Steps to reproduce: 1. Compile the source code. % i686-w64-mingw32-gcc -o shortmsg.exe shortmsg.c -lwinmm 2. Setup your favorite MIDI device, e.g. Timidity++. % timidity -iA & 3. Run the executable (argument -1 means we use the MIDI mapper). % wine shortmsg.exe -1 Expected result: We can hear the piano voice, C, D, E and F. Actual result: We can hear the piano voice, only C. [1] http://retropc.net/pi/xm6/index.html [2] http://retropc.net/x68000/software/sound/rc/sted2/ -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 52975] New: VTFEdit fails to start: err:module:LdrInitializeThunk "MSVCP80.dll" failed to initialize, aborting
by WineHQ Bugzilla 27 Mar '23

27 Mar '23

https://bugs.winehq.org/show_bug.cgi?id=52975 Bug ID: 52975 Summary: VTFEdit fails to start: err:module:LdrInitializeThunk "MSVCP80.dll" failed to initialize, aborting Product: Wine Version: 7.8 Hardware: x86-64 URL: https://web.archive.org/web/20191223154323/http://neme sis.thewavelength.net/files/files/vtfedit133.exe OS: Linux Status: NEW Keywords: download, patch Severity: normal Priority: P2 Component: msvcrt Assignee: wine-bugs(a)winehq.org Reporter: xerox.xerox2000x(a)gmail.com Distribution: --- Created attachment 72344 --> https://bugs.winehq.org/attachment.cgi?id=72344 patch Hi, someone reported on userforum troubles with this program: https://forum.winehq.org/viewtopic.php?f=2&t=36504 (The program is apparently from https://nemstools.github.io/pages/VTFLib-Download.html and already archived on Web archive) Fails to start: 0184:err:module:LdrInitializeThunk "MSVCP80.dll" failed to initialize, aborting Attached patch that fixes the bug. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 4

[Bug 52841] New: leverless arcade controller SOCD cleaning regression
by WineHQ Bugzilla 27 Mar '23

27 Mar '23

https://bugs.winehq.org/show_bug.cgi?id=52841 Bug ID: 52841 Summary: leverless arcade controller SOCD cleaning regression Product: Wine Version: 7.0 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: namtsui(a)gmail.com Distribution: --- Created attachment 72236 --> https://bugs.winehq.org/attachment.cgi?id=72236 fix downstream bug: https://github.com/ValveSoftware/Proton/issues/5527 There is a regression in wine SDL. I tested wine 7.0 using Linux 5.17.2. I think this is the commit to blame: https://github.com/wine-mirror/wine/commit/9cf1e8353cf05af1009e3e5d40b62f0e… See the file: wine-7.0/dlls/winebus.sys/bus_sdl.c https://github.com/wine-mirror/wine/blob/6d4ec1255acceec7152ed98764ee29991a… Leverless arcade controllers have all-buttons. One such controller is the hitbox controller from the company hitbox. It has four directional buttons mapped to DPAD. It has simultaneous opposite cardinal direction (SOCD) cleaning. If you hold down + up, it should output up. If you hold left + right, it should output nothing at all (neutral). I added print statements. See the attached fix. In clip 1, I demonstrate SDL2 events when down and up are held simultaneously during a jump for a while: hold down (DOWN press event) hold up (DOWN release event. UP press event.) hold both for a while release all (UP release event. DOWN release event.) [1] https://clips.twitch.tv/PlausibleSparklingButterJonCarnage-1nJQjUmS_kATb5Y6 In clip 2 the actual bug is shown. hold down (DOWN press event) press up (DOWN release event. UP press event.) steps 1 to 2 were demonstrated in clip 1. release up (DOWN press event. UP release event.) keep holding down [2] https://clips.twitch.tv/FunnyPlayfulClintmullinsArgieB8-p3pUOVQuS-eA8oqi The UP release event at the end in step 3 causes the axis to be reset to 0. This ignores the DOWN press event immediately preceding it. Clip 3 shows after the proposed fix is applied. [3] https://clips.twitch.tv/RacyNeighborlyCookiePeteZaroll-2wwLnflwjAa3ZlFz -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 52686] New: DateAdd not implemented
by WineHQ Bugzilla 27 Mar '23

27 Mar '23

https://bugs.winehq.org/show_bug.cgi?id=52686 Bug ID: 52686 Summary: DateAdd not implemented Product: Wine Version: 5.0 Hardware: x86-64 OS: Mac OS X Status: UNCONFIRMED Severity: normal Priority: P2 Component: vbscript Assignee: wine-bugs(a)winehq.org Reporter: sergey.bychkow(a)gmail.com Created attachment 72024 --> https://bugs.winehq.org/attachment.cgi?id=72024 Sample script A call to DateAdd function breaks VBScript. Sample (testdateadd.vbs): 1> aDateFrom = Now 2> MsgBox "Now: " & aDateFrom 3> aDateFrom = DateAdd("h", 1, aDateFrom) 4> MsgBox "+1h: " & aDateFrom $ wine wscript testdateadd.vbs Line 2 shows MsgBox, but line 4 does not execute. Errors (error.log): 0009:fixme:variant:get_date_format ignoring flags 10 0009:fixme:vbscript:Global_DateAdd 0009:fixme:wscript:ActiveScriptSite_OnScriptError () -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 53005] New: quartz:systemclock Fails after timeGetTime() wraps
by WineHQ Bugzilla 27 Mar '23

27 Mar '23

https://bugs.winehq.org/show_bug.cgi?id=53005 Bug ID: 53005 Summary: quartz:systemclock Fails after timeGetTime() wraps Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: quartz Assignee: wine-bugs(a)winehq.org Reporter: fgouget(a)codeweavers.com Distribution: --- Created attachment 72373 --> https://bugs.winehq.org/attachment.cgi?id=72373 Use GetTickCount64() instead of timeGetTime() in quartz:systemclock quartz:systemclock fails on fg-deb64: systemclock.c:186: Test failed: Got timestamps 43062836670000, 113163710000, 43062836670000. https://test.winehq.org/data/patterns.html#quartz:systemclock The issue is that timeGetTime() wrapped after 49.71 days (2^32 milliseconds) of uptime, causing it to no longer match the values returned by IReferenceClock_GetTime(). The test started using timeGetTime() in the commit below: commit bf5b35f19b841e6352c32ca7c6671d9172636871 Author: Zebediah Figura <zfigura(a)codeweavers.com> AuthorDate: Thu Oct 21 12:41:11 2021 -0500 quartz: Use the performance counter for the system clock. Native probably uses timeGetTime() as a source. That doesn't actually match the performance counter on Windows, but it does on Wine, and accessing the counter directly is slightly more efficient anyway. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51684 Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> The commit made two changes: GetTickCount*() -> timeGetTime() in the test GetTickCount64() -> QueryPerformanceCounter() in SystemClockImpl_GetTime() Before this commit the test was failing on Windows because the GetTickCount*() values and SystemClockImpl_GetTime() were a bit out of sync. So while switching to GetTickCount64() in the test fixes the issue in Wine and does not seem to cause failures on Windows it's not clear that this is correct either. It would also be nice to see what happens to this test on Windows after 49.7 days of uptime. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 52534] New: ListView: multi select never sends LVN_ODSTATECHANGED
by WineHQ Bugzilla 27 Mar '23

27 Mar '23

https://bugs.winehq.org/show_bug.cgi?id=52534 Bug ID: 52534 Summary: ListView: multi select never sends LVN_ODSTATECHANGED Product: Wine Version: 7.1 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs(a)winehq.org Reporter: winehq-bugs(a)angelohaller.com Distribution: --- When using a ListView in virtual mode (LVS_OWNERDATA) and selecting multiple rows (holding down shift and selecting) the message code LVN_ODSTATECHANGED is never sent. Looking through the wine source, there is definitely code present sending LVN_ODSTATECHANGED, this however never reaches the application and hence is a bug. Running the same application in Windows 7 will however send the LVN_ODSTATECHANGED code. This seems to be true for ALL programs using LVS_OWNERDATA and supporting multi select. This is an issue that arose working on https://github.com/libui-ng/libui-ng/pull/73 A nicer example to reproduce would be from the `Windows classic samples`. I forked the official Microsoft repo to add some debug printing: 1. Clone https://github.com/szanni/Windows-classic-samples 2. Change to directory Samples/Win7Samples/winui/controls/common/vlistvw 3. Build VListVw (I cross compile via `x86_64-w64-mingw32-gcc VListVw.c -lcomctl32` but using the vcproj should work too?) or use the test binary a.exe (linked at the bottom) 4. Run the resulting .exe 5. Select a cell (should print `LVN_ITEMCHANGED`) 6. Hold down `shift` and select a cell a few rows down below. On Windows 7 step 6. triggers the message `LVN_ODSTATECHANGED` to be emitted (as can be seen in the debug print statements). wine however never sends this message. This is contrary to the documentation provided in https://docs.microsoft.com/en-us/windows/win32/controls/lvn-itemchanged#rem… and behavior developers rely on. Test binary: https://github.com/szanni/Windows-classic-samples/blob/main/Samples/Win7Sam… -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 8

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-bugs November 2022