[Bug 46019] Multiple NSIS 2.x based installers fail due to invalid module handle passed to 'kernel32.FreeLibrary', causing code dll unmapped as data dll ( Adobe Digital Editions 4.5.x, ConceptDraw Office 4)

https://bugs.winehq.org/show_bug.cgi?id=46019

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |35d202fc0982da4e7ae35964144
                   |                            |82318af118acb

--- Comment #8 from Anastasius Focht  ---
Hello folks,

this is fixed by commit
https://source.winehq.org/git/wine.git/commitdiff/35d202fc0982da4e7ae3596414...
("kernel32: Validate handle before freeing a LOAD_LIBRARY_AS_DATAFILE
module.").

Thanks Alexandre

--- snip ---
$ WINEDEBUG=+seh,+relay wine ./ConceptDrawOffice4Install.exe >>log.txt 2>&1
...
002a:Call KERNEL32.GetModuleHandleA(00409f50
"C:\users\focht\Temp\nscc5e9.tmp\System.dll") ret=00401f82
002a:Ret  KERNEL32.GetModuleHandleA() retval=00000000 ret=00401f82
002a:Call KERNEL32.LoadLibraryExA(00409f50
"C:\users\focht\Temp\nscc5e9.tmp\System.dll",00000000,00000008)
ret=00401f92
...
002a:Ret  KERNEL32.LoadLibraryExA() retval=00d80000 ret=00401f92
002a:Call KERNEL32.GetProcAddress(00d80000,00409b50 "Call") ret=00401fa2
002a:Ret  KERNEL32.GetProcAddress() retval=00d8198f ret=00401fa2 
...
002a:Call KERNEL32.lstrcpyA(00177148,00163534
"kernel32::GetCurrentProcess()i.s") ret=00d81584
002a:Ret  KERNEL32.lstrcpyA() retval=00177148 ret=00d81584 
...
002a:Call KERNEL32.FreeLibrary(00d8198f) ret=0040200d
002a:Ret  KERNEL32.FreeLibrary() retval=00000000 ret=0040200d 
...
002a:Call KERNEL32.GetModuleHandleA(00409f50
"C:\users\focht\Temp\nscc5e9.tmp\System.dll") ret=00401f82
002a:Ret  KERNEL32.GetModuleHandleA() retval=00d80000 ret=00401f82
002a:Call KERNEL32.GetProcAddress(00d80000,00409b50 "Call") ret=00401fa2
002a:Ret  KERNEL32.GetProcAddress() retval=00d8198f ret=00401fa2
...
002a:Call KERNEL32.lstrcpyA(00179468,0017797c "advapi32::OpenProcessToken(iR0,
i0x0008|0x0020, *i.R1)i.R0") ret=00d81584
002a:Ret  KERNEL32.lstrcpyA() retval=00179468 ret=00d81584 
...
002a:Call KERNEL32.GetProcAddress(7e610000,00179c78 "OpenProcessToken")
ret=00d82310
002a:Ret  KERNEL32.GetProcAddress() retval=7e624450 ret=00d82310 
...
002a:Call KERNEL32.FreeLibrary(00d8198f) ret=0040200d
002a:Ret  KERNEL32.FreeLibrary() retval=00000000 ret=0040200d 
...
--- snip ---

$ wine --version
wine-4.5-222-g8ee1e3453e

Regards