[Bug 52673] Missing IShellItemImageFactory implementation for ShellItem.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52673

--- Comment #7 from Jinoh Kang  ---
(In reply to Byeongsik Jeon from comment #3)
> How about trying a simple patch that changes the
> ShellItem_IShellItemImageFactory_GetImage() return value from E_NOTIMPL to
> S_OK?
>
> This alone allowed the KakaoTalk crash to be avoided.
>
> Many cases can be found using fake return value in other Wine (full) stub
> function implementations.

For future reference: yes, returning E_NOTIMPL was not an option because it
will skip setting a certain bitmap pointer or allocating an internal bitmap
object which later causes NULL pointer dereference.  Returning S_OK but not
returning any HBITMAP at all would technically avoid the crash, but it's
against COM convention to leave [out] pointer uninitialized and leads to
confusing results.