https://bugs.winehq.org/show_bug.cgi?id=25857
--- Comment #70 from Paul Gofman gofmanp@gmail.com --- (In reply to super_man from comment #68)
There is no doubt you know what you are doing since you have done so enormous amount of work towards these patches an reform them so quickly, but if I would be you I would split the patches smaller. It would make regression testing later easier since regression wouldnt point huge patch-sets and it would make easier to get the patches in.
This is not an enormous amount of work really.
A patchset attached to this bug is not a solid patchset, it is just a cat of not fully related patches which I made eventually while testing preshaders on real applications. The biggest patches concerning initial implementation are already upstream actually (the remaining 4 patches of that series are smaller). There was a great desire to split them further but it was not so easy to do in case of preshaders implementation provided that each patch should end up with code complete and verifyable in some sense. I originally made an implementation, unit tests and tested on some real apps, and then it was splitted into 8 pieces.
The only reason I've put this joint patchset here is that it gives more chances to test the main functionality in applications which would otherwise not possible for the most of them due to many pieces missing (there are still many, but this gives some chance at least :). Most of separate patches in this patchset are not big really, and some of them which are preparing for upstream (like IsParameterUsed implementation, added opcode) already have unit tests, and there is also a patch with just a unit test which was easier to leave in range rather than to remove.
Pools (shared parameters) implementation here really at least requires unit testing, a bit ugly, could possibly be splitted and most likely buggy in certain aspects, but I did not intend it for upstream. Making just a quick implementation which allows some apps to pass takes much less efforts than making it complete and fully tested.
Having said all this, I do not deny that you are right and making patches smaller is preferred while I often tend to make them bigger, all I wanted to say that it is not so easy in some cases.
It would be also really good if you could take a look some of the other wine bugs when you are done with this. Not everyone has the skills to fix these things.
If you have some interesting bugs to track down, please point me :) I will look if I have anything to do with them whenever possible.