https://bugs.winehq.org/show_bug.cgi?id=48302
Matteo Bruni matteo.mystral@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1
--- Comment #11 from Matteo Bruni matteo.mystral@gmail.com --- (In reply to Matteo Bruni from comment #10)
(In reply to Paul Gofman from comment #9)
This issue is not a regression, so probably a no go during the code freeze. I was planning to finalize the unit test and suggest the patch upstream after code freeze (I guess late January or so).
I think the patch should be okay for code freeze, it's still a bug fix with very low risk. We do want to test (not necessarily Wine tests) which d3dx9 versions require the flag. FWIW 3a5688a795532640bb32bd4c3e9961c6ab9f19fa implies the behavior changed with d3dx9_37 for effect shaders.
Eh, I was referring to the d3dx9 patch while you were talking about the wined3d change. Actually the wined3d one is probably also okay, we don't restrict acceptable patches to regression fixes only (especially when there are still a few weeks to go) and the change is very contained. Of course others might disagree so the patch can still end up deferred.