http://bugs.winehq.org/show_bug.cgi?id=16281
--- Comment #19 from Andrew Riedi andrewriedi@gmail.com 2010-01-01 22:01:25 ---
The 16-bit cursors still aren't fully separated from the 32-bit cursors. I've attached a patchset that separates things a lot more (patches 1-3), then implements a new layout for 32-bit cursors (patch 4), then adds animated cursor support (patch 5). If anyone has a chance to look it over I'd appreciate some feedback.
Hello. I briefly looked over your patches. I could be wrong, but I don't think AJ will go for wine-specific extensions. eg. WINE_CursorIcon32To16(), WINE_get_cursoricon_ptr, LR_WINE16BIT, etc. As far as the .ani struct goes, it might be better to allocate only one piece of memory, but that is not all that important.
When I talked to AJ most recently, the idea was to pass a handle to winex11.drv's create_cursor() and have separate handles and structs for 16-bit and 32-bit icons/cursors. I didn't get time to ask for details on how he would want that done. It seems that with this approach we will either have to duplicate some code or make a 32->16 conversion function so that we can use eg. 32-bit LoadImageA() to implement the 16-bit loading functions. Of course, with this idea, conversion will only need to happen once.