[Bug 4853] New: Regression: new systray implementation doesn't work with flashget

[Wine Bugs]

http://bugs.winehq.org/show_bug.cgi?id=4853

Summary: Regression: new systray implementation doesn't work with
                    flashget
           Product: Wine
           Version: 0.9.9.
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: wine-msi
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

With the 0.9.9 version of wine, my flashget won't start anymore.
On start up, it displays a message box saying "failed to create empty document".

The first debug message I noticed is a timeout when starting "explorer /systray".
So I fixed the TIMEOUT value, and the message disappears.

But flashget still gave me the same complaint.

After a lot of tracing, I found out that it's because of a special case that
wine handles differently than Windows.

The special case being:
When an app calls Shell_NotifyIcon, it passes to wine a NOTIFYICONDATA struct.
In this struct there's a uFlags field indicating what other fields are valid.
By valid it means it actually fills the field with some value. Usually it also
means the value itself is valid.
Except that an app can pass a NULL hIcon to this api call. On Windows the shell
just displays a blank icon. On current wine implementation, this api call fails.

if (nid->uFlags & NIF_ICON)
{
.....
if (!GetIconInfo(nid->hIcon, &iconinfo))
return FALSE;