[Bug 51017] Microsoft PowerToys installer crash inside RegOpenKeyExW

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51017

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Keywords|                            |download
            Summary|Microsoft PowerToys         |Microsoft PowerToys
                   |installer crashes           |installer crash inside
                   |                            |RegOpenKeyExW
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Louis Lenders  ---
Hi,

Confirming. This looks to be same bug as I opened a few months ago
(https://bugs.winehq.org/show_bug.cgi?id=49858)

I will resolve my bug as duplicate though, as this has a better download/way to
install

Somehow it looks as if the stringpointer passed to RoGetActivationFactory is
invalid and causes a crash. I don`t know where that invalid string comes from

I put a hack like at the end of this writing in roapi.c, and that allowed me to
 get it installed, but it doesn't start either.

A relay log showed it was trying to load Windows.Data.dll and Windows.dll, i
don`t know what those dlls are, they are not provided by wine in any case.

Hack to get it installed:

diff --git a/dlls/combase/roapi.c b/dlls/combase/roapi.c
index 53da979d681..6f3c7fa40d4 100644
--- a/dlls/combase/roapi.c
+++ b/dlls/combase/roapi.c
@@ -45,7 +45,8 @@ static HRESULT get_library_for_classid(const WCHAR *classid,
WCHAR **out)
     WCHAR *buf = NULL;

*out = NULL;
-
+    FIXME(" %s \n", debugstr_w(classid));
+    if (IsBadStringPtrW(classid,MAX_PATH)) return E_INVALIDARG;
     /* load class registry key */
     if (RegOpenKeyExW(HKEY_LOCAL_MACHINE,
L"Software\Microsoft\WindowsRuntime\ActivatableClassId",
                       0, KEY_READ, &hkey_root))