http://bugs.winehq.org/show_bug.cgi?id=5024
--- Comment #32 from Erich Hoover ehoover@mines.edu 2008-01-05 12:23:15 --- (In reply to comment #31)
I'm nominating this one for wine-1.0. It's clear what the cause of the bug is, and there's even a patch in comment #29, but Eric didn't respond anymore, but it should be possible to fix this before wine-1.0
Sorry, I've been pretty busy for quite a while and then forgot about it. I would not feel comfortable submitting this patch without the test code as well, which is something that you did. So, I will submit my patch if you would submit your test code patch (valid against latest git) with a title like "Fix for WritePrivateProfileString [1/2]" and format the message along with it something like this: ------ Real Name: <your real name, not an alias> Description: Tests for WritePrivateProfileString error cases. These tests show a problem with WritePrivateProfileString that prevents Thief: Deadly Shadows from installing properly (see Bug #5024). Part 2/2 (to be submitted by Erich Hoover) contains a proposed fix. Changelog: kernel32: Fix for WritePrivateProfileString [1/2] ------
By approaching the patch in this way it will have a much greater likelihood of being included. The guidelines for submissions are rather spread out but a summary of what helps is: 1) Only submit your own work 2) Submit all patches as separate emails with a plain text patch attachment 3) Explain the problem you are trying to fix (or the problem your test cases covers) 4) Make all changes as simple and crystal clear as possible