[Bug 48398] New: [PATCH] build failure on arm64 with new gcc

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48398

Bug ID: 48398
           Summary: [PATCH] build failure on arm64 with new gcc
           Product: Wine
           Version: 5.0-rc1
          Hardware: aarch64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Description:
../../tools/winegcc/winegcc -o d3dcompiler_47.dll.so --wine-objdir ../.. -fPIC
-fasynchronous-unwind-tables -shared d3dcompiler_47.spec -mno-cygwin
asmparser.o blob.o bytecodewriter.o compiler.o main.o preproc.o reflection.o
utils.o asmshader.tab.o hlsl.tab.o ppy.tab.o asmshader.yy.o hlsl.yy.o ppl.yy.o
version.res ../../dlls/dxguid/libdxguid.a ../../dlls/uuid/libuuid.a
-Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now
-Wl,-rpath,/usr/lib/aarch64-linux-gnu/wine
../d3dx9_36/effect.c:1472:12: error: result of comparison of unsigned enum
expression < 0 is always false
[-Werror,-Wtautological-unsigned-enum-zero-compare]
    if (op < 0 || op > SCT_PSINT)
        ~~ ^ ~
1 error generated.

Author: Gianfranco Costamagna

Forwarded: pending
Last-Update: 2019-12-31

--- wine-5.0~rc1.orig/dlls/d3dx9_36/effect.c
+++ wine-5.0~rc1/dlls/d3dx9_36/effect.c
@@ -1469,7 +1469,7 @@ static HRESULT d3dx_set_shader_const_sta
     D3DXVECTOR4 value;
     HRESULT ret;

-    if (op < 0 || op > SCT_PSINT)
+    if (op > SCT_PSINT)
     {
         FIXME("Unknown op %u.\n", op);
         return D3DERR_INVALIDCALL;

An enum starting with 0 can't obviously assume negative values...