[Bug 46635] git for windows works or crashes depending on how its invoked

https://bugs.winehq.org/show_bug.cgi?id=46635

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
           Keywords|                            |download
     Ever confirmed|0                           |1
                 CC|                            |[e-mail]

--- Comment #4 from Louis Lenders  ---

Hi i can confirm there is a crash. seems like a problem in NtQueryObject.

002f:Call msvcrt._get_osfhandle(00000001) ret=005db4b9
002f:Ret  msvcrt._get_osfhandle() retval=000000b4 ret=005db4b9
002f:Call KERNEL32.GetFileType(000000b4) ret=005db4c5
002f:Ret  KERNEL32.GetFileType() retval=00000003 ret=005db4c5
002f:Call ntdll.NtQueryObject(000000b4,00000001,0032f710,000003fe,0032f70c)
ret=005db512
002f:Ret  ntdll.NtQueryObject() retval=00000000 ret=005db512
002f:trace:seh:NtRaiseException code=c0000005 flags=0 addr=0x5db52b ip=5db52b
tid=002f
002f:trace:seh:NtRaiseException  info[0]=0000000000000001
002f:trace:seh:NtRaiseException  info[1]=0000000000000000

I might be off  (little late) but msdn suggests enumeration for the
OBJECT_INFORMATION_CLASS is wrong in wintern.h.
(https://docs.microsoft.com/en-us/windows/desktop/api/winternl/nf-winternl-nt...)

msdn suggests
ObjectBasicInformation =0
ObjectTypeInformation =1

and wintern.h says ObjectTypeInformation =2 or am I missing something/see it
wrong?

The following hack makes crash dissapear:

diff --git a/include/winternl.h b/include/winternl.h
index 46dac7e481..9ff5358b6e 100644
--- a/include/winternl.h
+++ b/include/winternl.h
@@ -824,8 +824,8 @@ typedef enum _KEY_VALUE_INFORMATION_CLASS {

typedef enum _OBJECT_INFORMATION_CLASS {
     ObjectBasicInformation,
-    ObjectNameInformation,
     ObjectTypeInformation,
+    ObjectNameInformation,
     ObjectAllInformation,
     ObjectDataInformation
 } OBJECT_INFORMATION_CLASS, *POBJECT_INFORMATION_CLASS;

I did 
/tmp/wine-git-bug/.build$ wine ../tools/bin/cmake.exe .. -G "Unix Makefiles"

With the hack/patch:
Is this expected output?

wine: cannot find L"C:\windows\system32\winemenubuilder.exe"
000b:err:wineboot:ProcessRunKeys Error running cmd
L"C:\windows\system32\winemenubuilder.exe -a -r" (2)
0027:fixme:winsock:WS_EnterSingleProtocolW unknown Protocol <0x00000000>
0027:fixme:winsock:WS_EnterSingleProtocolW unknown Protocol <0x00000000>
CMake Error at CMakeLists.txt:8 (message):
  GIT_VERSION= git version 2.20.1.windows.1

-- Configuring incomplete, errors occurred!
0027:fixme:ver:GetCurrentPackageId (0xabfcf0 (nil)): stub