[Bug 49852] Performance regression in "msvcrt: Use correct code page in _write when outputing to console."

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49852

Martin Storsjö  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Martin Storsjö  ---
Further bisecting shows that the runtime doubled further in
ab6056d6774310162ef268ca6af5e3ad2e556a4e, "kernel32: Use
IOCTL_CONDRV_WRITE_CONSOLE in WriteConsoleW when possible.".

I.e., originally the attached test app ran in around 1 second, in 081d25d4b9
(msvcrt: Use correct code page) it regressed to 13 seconds (in my recent tests)
and further on to 24 seconds in ab6056d677 (kernel32: Use
IOCTL_CONDRV_WRITE_CONSOLE).

Not sure what to say about these changes vs performance, as I presume the
changes are done for correctness sake - but it's a bit surprising to wait for
that long, for a test app that earlier ran in a second or two.