[Bug 37370] Doom 3 (CD version) installer: 'cancel' button does nothing in 'Please insert: DOOM 3 Disk x' dialog

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=37370

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |FIXED
            Summary|Doom3 CD version installer  |Doom 3 (CD version)
                   |- cancel buton does         |installer: 'cancel' button
                   |nothing.                    |does nothing in 'Please
                   |                            |insert: DOOM 3 Disk x'
                   |                            |dialog

--- Comment #9 from Anastasius Focht  ---
Hello folks,

I've found a distributed backup for testing.

--- snip ---
$ ll Doom\ 3\ (USA)\ (Disc\ *
-rw-rw-r--. 1 focht focht 579640992 Dec 24  1996 'Doom 3 (USA) (Disc 1).bin'
-rw-rw-r--. 1 focht focht        87 Dec 24  1996 'Doom 3 (USA) (Disc 1).cue'
-rw-rw-r--. 1 focht focht 672258048 Dec 24  1996 'Doom 3 (USA) (Disc 2).bin'
-rw-rw-r--. 1 focht focht        87 Dec 24  1996 'Doom 3 (USA) (Disc 2).cue'
-rw-rw-r--. 1 focht focht 640722432 Dec 24  1996 'Doom 3 (USA) (Disc 3).bin'
-rw-rw-r--. 1 focht focht        87 Dec 24  1996 'Doom 3 (USA) (Disc 3).cue'
--- snip ---

Loading/mounting:

--- snip ---
$ cdemu load 0 "Doom 3 (USA) (Disc 1).cue"

$ udisksctl mount -b /dev/sr1
Mounted /dev/sr1 at /run/media/focht/DOOM3_1.

$ ll ~/.wine/dosdevices/ | grep /dev/sr1
lrwxrwxrwx. 1 focht focht  8 Jul  5 13:08 e:: -> /dev/sr1
--- snip ---

--- snip ---
$ WINEDEBUG=+msgbox wine "e:\setup.exe"
...
fixme:apphelp:ApphelpCheckInstallShieldPackage stub: 0x33f39c L"E:\Doom 3.msi"
...
trace:msgbox:MSGBOX_OnInit L"The CD Key you entered appears to be valid. 
Activision will never ask you for your CD key.  Don't tell it to anyone!  Don't
lose your CD Key!"
...
trace:msgbox:MSGBOX_OnInit L"Please insert: DOOM 3 Disk 2"
<cancel clicked>
trace:msgbox:MSGBOX_OnInit L"Please insert: DOOM 3 Disk 2"
<cancel clicked>
trace:msgbox:MSGBOX_OnInit L"Please insert: DOOM 3 Disk 2"
<cancel clicked>
trace:msgbox:MSGBOX_OnInit L"Please insert: DOOM 3 Disk 2"
<cancel clicked>
trace:msgbox:MSGBOX_OnInit L"Please insert: DOOM 3 Disk 2"
...
--- snip ---

Every time the 'cancel' button is clicked the dialog window reappears.

With commit
https://source.winehq.org/git/wine.git/commitdiff/77e3d3372fd361bb58d68325fd...
("msi: Use MsiProcessMessage() to send error messages.") the dialog window
closes after 'cancel'.

Part of Wine 2.15 release.

Thanks Zeb.

===

There was another follow-up ole/rpcrt4 issue that prevented the installer (COM
server) from exiting. The main UI / background and dialog with progress bar was
still visible

--- snip ---
$ WINEDEBUG=+msgbox wine "e:\setup.exe"
...
0031:fixme:apphelp:ApphelpCheckInstallShieldPackage stub: 0x33f3fc L"e:\Doom
3.msi"
...
0031:trace:msgbox:MSGBOX_OnInit L"The CD Key you entered appears to be valid. 
Activision will never ask you for your CD key.  Don't tell it to anyone!  Don't
lose your CD Key!"
...
0031:trace:msgbox:MSGBOX_OnInit L"Error 1311.Source file not found: DOOM 3 Disk
2.  Verify that the file exists and that you can access it."
<cancel clicked>
0051:err:msi:ACTION_InstallFiles Failed to ready media for L"pak000.pk4"
0051:err:msi:ITERATE_Actions Execution halted, action L"InstallFiles" returned
2
...
0031:trace:msgbox:MSGBOX_OnInit L"Error: -2  File not found.\r\n"
...
--- snip ---

--- snip ---
C:\PROG~5P2\COMM~CP1\INST~JM1\Driver\9\INTE~MEX\IDriver.exe -Embedding
--- snip ---

That problem was fixed in between Wine 3.20 and 3.21 release.

--- snip ---
$ WINEDEBUG=+msgbox wine "e:\setup.exe"
...
005f:fixme:apphelp:ApphelpCheckInstallShieldPackage stub: 0x33ef4c L"e:\Doom
3.msi"
...
005f:trace:msgbox:MSGBOX_OnInit L"The CD Key you entered appears to be valid. 
Activision will never ask you for your CD key.  Don't tell it to anyone!  Don't
lose your CD Key!"
005f:trace:msgbox:MSGBOX_OnInit L"Error 1311.Source file not found: DOOM 3 Disk
2.  Verify that the file exists and that you can access it."
<cancel clicked>
009e:err:msi:ACTION_InstallFiles Failed to ready media for L"pak000.pk4"
009e:err:msi:execute_script Execution of script 0 halted; action
L"InstallFiles" returned 1612
009e:err:msi:ITERATE_Actions Execution halted, action L"InstallFinalize"
returned 1612
005f:err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment,
should have been 0x5e0000009e
005f:trace:msgbox:MSGBOX_OnInit L"Error: -1612  Installation source is
missing.\r\n"
005f:err:rpc:RpcServerUnregisterIf not found for object (null)
--- snip ---

* dialog window closed
* installer exits cleanly

Likely of these:

--- snip ---
$ git log --oneline wine-3.20...wine-3.21 -- dlls/rpcrt4 dlls/oleaut32

f848d03f95e rpcrt4: Fix handling of FC_ALIGNM* directives.
9a46a1fc9e1 rpcrt4/tests: Add a test for FC_ALIGNM* directives.
c94314085c4 rpcrt4: Handle large arrays in EmbeddedComplexSize().
2cba0ed9442 oleaut32/tests: Add some tests for marshalling of coclasses.
94f4b49d78f oleaut32: Handle coclasses in ITypeInfo_Invoke().
ab6d4a9d3dc oleaut32: Pass a HREFTYPE to get_iface_guid.
5d44b1d4bd2 rpcrt4: Write type format strings for coclasses.
b7dad74f532 oleaut32/tests: Add test for calling function with instance and
VARIANT return type.
b73972b9df0 oleaut32: Fix argument order with instance and VARIANT return type.
e24f2f3b909 rpcrt4: Support delegated proxies on ARM.
da383cb8e4f rpcrt4: Support stubless proxies on ARM.
077b4391d44 oleaut32: Rip out the old typelib marshaller.
0c642cc043f rpcrt4: Write the floating-point mask on x86-64.
d3bc9721f7e rpcrt4: Delegate to the parent if it is not IUnknown.
f6b1341aa2b rpcrt4: Retrieve the underlying interface for dual interfaces.
60f5e23ca8f rpcrt4: Write type format strings for Automation types.
--- snip ---

Regards