[Bug 51465] EVE Online launcher crashes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51465

--- Comment #15 from Zebediah Figura  ---
(In reply to algebro from comment #14)
> I just added a small hacky patch to cryptopp to manually load msvcrt.dll as
> follows:
>
> hModule = GetModuleHandle("msvcrtd");
>    if (!hModule) 
>    	hModule = GetModuleHandle("msvcrt");
>    if (!hModule)
>    	hModule = LoadLibrary("msvcrt.dll");
>
> After recompiling cryptopp.dll and replacing the one that ships with the EVE
> Windows launcher, it works fine on Wine 6.12. So it looks like Zebediah was
> spot on.
>
> @Zebediah, should we do anything about this on the Wine side (like look at
> linking against msvcrt), or just patch this upstream in cryptopp to have it
> load the library if it's not present?

Conceptually it'd be nice for cryptopp to fix the bug themselves, yes. (Note
that you probably want to always use LoadLibrary instead of trying
GetModuleHandle first.) That said, we may need to fix it in Wine anyway, for
other applications.