[Bug 16283] Graphmatica crashes

http://bugs.winehq.org/show_bug.cgi?id=16283

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www8.pair.com/ksoft/
                   |                            |Graphmatica20f_setup.exe

--- Comment #8 from Nikolay Sivov   2009-10-14 12:46:40 ---
(In reply to comment #7)
> This program passes an invalid iString to CreateToolbarEx - I've contacted the
> author and he said he forgot to initialize the iString for separators. He has a
> fixed version, but if there is an app that depends on it, maybe we should also
> add an IsBadStringPtr or an exception handler in TB_ADDBUTTON - my experience
> with this message is that Windows is resillient to invalid pointers. We should
> also check what iString is returned from TB_GETBUTTONINFO for such a button.

That's strange. We add buttons with TB_ADDBUTTONSW internally during
CreateToolbarEx, separators' iString-s are handled with a special path:
---
        if (btnPtr->fsStyle & BTNS_SEP)
            btnPtr->iString = -1;
---
So we don't depend on garbage passed here for iString.

Anyway I can't crash it on wine-1.1.31-159-ge52115d (on startup I mean), I'm
trying version 2.0f.