[Bug 39377] New: Add support for 'msidbControlAttributesFormatSize' in static text controls to format and label properties such as 'PrimaryVolumeSpaceRequired' (SkySaga installer)

https://bugs.winehq.org/show_bug.cgi?id=39377

Bug ID: 39377
           Summary: Add support for 'msidbControlAttributesFormatSize' in
                    static text controls to format and label properties
                    such as 'PrimaryVolumeSpaceRequired' (SkySaga
                    installer)
           Product: Wine
           Version: 1.7.52
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: msi
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Hello folks,

continuation of bug 39307

Prerequisites:

* 'winetricks -q dotnet40' (if Wine-Mono not present)
* Windows version set to 'Windows Vista+'

--- snip ---
...
0035:trace:msi:msi_set_property 0x15bbf8 L"PrimaryVolumeSpaceRequired" L"19380"
-1 
...
0035:trace:msi:msi_dialog_add_control L"Static", L"Description", 00090003,
L"Setup requires [PrimaryVolumeSpaceRequired] in:", 00020000 
...
0035:trace:msi:MSI_FormatRecordW L"Setup requires [PrimaryVolumeSpaceRequired]
in:" 
...
0035:trace:msi:msi_get_property returning L"19380" for property
L"PrimaryVolumeSpaceRequired" 
...
0035:Call user32.CreateWindowExW(00000000,7ce97ae0 L"Static",00198d58 L"Setup
requires 19380
in:",50020000,000000d9,000000a4,00000183,00000017,00030080,00000000,00000000,00000000)
ret=7ce272f3 
...
--- snip ---

This number displayed is 512 byte units.

I found this in the remark section of 'PrimaryVolumeSpaceRequired' property in
MSDN:

https://msdn.microsoft.com/en-us/library/aa370849%28v=vs.85%29.aspx

--- quote ---
PrimaryVolumeSpaceRequired property

The installer sets the value of the PrimaryVolumeSpaceRequired property to a
string representing the total number of bytes required by all selected features
on the volume referenced by the PrimaryVolumePath property. As with the
PrimaryVolumeSpaceAvailable property, this number is expressed in units of 512
bytes.

Remarks

Note if this value is to be displayed within a static Text control, the
FormatSize bit can be used to automatically format and label this number in
units of kilobytes or megabytes as appropriate.
--- quote ---

https://msdn.microsoft.com/en-us/library/aa368608%28v=vs.85%29.aspx

'FormatSize' is indeed applicable here (attributes of control = 0x00090003).

The value should be formatted with proper units to be meaningful.

$ sha1sum SkySagaEUInstaller.exe 
ee55d51213031fdf8d71475434c18ecd7caef9eb  SkySagaEUInstaller.exe

$ du -sh SkySagaEUInstaller.exe 
11M    SkySagaEUInstaller.exe

$ wine --version
wine-1.7.52

Regards