[Bug 25857] Multiple games (Stronghold 2, Need for Speed: Carbon demo, Purge) fail to draw correctly because of ID3DXEffectImpl_*Pass calls

https://bugs.winehq.org/show_bug.cgi?id=25857

--- Comment #74 from Paul Gofman  ---
(In reply to Wylda from comment #73)
> Created attachment 54243 [details]
> native D3DXCreateEffect vs. native D3DXCreateEffect + winestaging's DXTn
>
> I gave a try v12 from patches queue + 05..09 (10th already got in). Fifa,
> NFS MW, NFS Carbon still work perfectly.
>
> Then i tried CNC Red Alert 3. Without the patches you cant get pass the
> intro.
>
> With these patches you see intro and game menu. But when i enter the game, i
> see the black screen and maps and button in the corners.

I checked, this is due to currently pSkipConstants parameter for
D3DXCreateEffectEx is ignored in effect framework. The constants listed in this
string should be ignored by effect framework, application sets it itself though
d3d calls directly. I checked that:
- there are meaningfull constants in this string passed by application;
- some constants are indeed set by SetPixelShaderConstantF directly by
application;
- if to proxy native D3DXCreateEffectEx nullifying pSkipConstants, native
framework renders the same black as Wine.

So I will remember this as todo for effect framework but I do not have a patch
for that right now.