http://bugs.winehq.org/show_bug.cgi?id=10567
Summary: Return value mistake in msiexec.c Product: Wine Version: CVS/GIT Platform: All OS/Version: All Status: UNCONFIRMED Severity: trivial Priority: P2 Component: wine-programs AssignedTo: wine-bugs@winehq.org ReportedBy: patrick.a.moran@gmail.com
Created an attachment (id=9334) --> (http://bugs.winehq.org/attachment.cgi?id=9334) A patch that corrects the return value
I was just looking at the git source for msiexec.c, and noticed that in the msi_atou() function, it calculates the DWORD, then returns 0 instead of the calculated value. The file attached is a patch that simply returns the calculated return value instead of 0.
Please be gentle, this is a lot of firsts for me. It's the first time I've ever used git, generated a patch, used a bugzilla, or really submitted anything but a human-language translation to an open-source project. If my patch is not of the correct format, just let me know and I'll fix it. Also I wasn't sure if this is the correct venue for submitting this patch.