[Bug 12439] Regression: Age of Mythology: Installer page faults

http://bugs.winehq.org/show_bug.cgi?id=12439

Aric Stewart  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1

--- Comment #2 from Aric Stewart   2008-04-08 12:10:18 ---
That patch is not correct.

do you have where it crashes (line-number) or maybe you could give me a
backtrace or +imm  log?

-aric

(In reply to comment #0)
> The Age of Mythology installer page faults on startup from this regression:
>
> dd0c9300f99a9cc4a2ce1178a6fa7e40afe2dc8f is first bad commit
> commit dd0c9300f99a9cc4a2ce1178a6fa7e40afe2dc8f
> Author: Aric Stewart 
> Date:   Wed Apr 2 08:48:22 2008 -0500
> imm32: Keep track of context associations between HWND and HIMC.
>
> :040000 040000 5fa8a5f30dd144a8125c5216055517ee1b8bcca5
> 06afebe61003c92cf2fba84e53c1bf5819fe92b3 M      dlls
>
> Specifically, this fixes it:
>
> diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c
> index 0995fb6..0712d66 100644
> --- a/dlls/imm32/imm.c
> +++ b/dlls/imm32/imm.c
> @@ -356,6 +356,9 @@ HIMC WINAPI ImmAssociateContext(HWND hWnd, HIMC hIMC)
>  TRACE("(%p, %p):\n", hWnd, hIMC);
>
> - if (!hIMC)
> -
>    return NULL;
> - if (!IMM_GetThreadData()->defaultContext)
>        IMM_GetThreadData()->defaultContext = ImmCreateContext();