[Bug 51517] New: Incorrect spliiting of -Wl,key=value arguments in winegcc

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51517

Bug ID: 51517
           Summary: Incorrect spliiting of -Wl,key=value arguments in
                    winegcc
           Product: Wine
           Version: 6.13
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: tools
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

In wine 6.13, a regression is introduced where winegcc incorrectly split
"-Wl,--key=value" into two "-Wl,--key" and "-Wl,value" when passing to the
linker.

This is introduced in commit fcda0afdd429e11d75dc61f628e40a6c8973ce44 as meson
would somehow pass "-Wl,--out-implib=something" to winegcc. This commit should
be reverted for the following reasons:

* I believe this is a issue with meson passing the option in this particular
way. According to GNU ld documentation, parameters for "--out-implib" is in
fact space separated. In other words, the right way to invoke this option is
"-Wl,--out-implib,blah".

* This breaks other equal-sign separated option, for instance,
"-Wl,--build-id=sha1". In this case the linker will report "cannot find sha1:
No such file or directory" as winegcc splits this option into "-Wl,--build-id"
and "-Wl,sha1", which of course make no sense for the linker.

This issue is also present in the git master branch.