[Bug 18987] Some games using BINK engine v1.9x crash randomly on intro video playback (Prototype, Driver: San Francisco)

https://bugs.winehq.org/show_bug.cgi?id=18987

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Prototype doesn't run       |Some games using BINK
                   |reliably                    |engine v1.9x crash randomly
                   |                            |on intro video playback
                   |                            |(Prototype, Driver: San
                   |                            |Francisco)

--- Comment #19 from Anastasius Focht  ---
Hello folks,

refining summary since bug 28545 ("Driver: San Francisco - Fails to launch")
also references this bug.

"Driver: San Francisco" was mentioned in #wine-staging with +relay being a
"workaround":

--- quote ---
...
some game which crashes but works with relay, seems like some stack corruption
it uses the bink32 video decoding lib in async mode
and randomly crashes during the video decoding
...
if you enable snoop, you will see that it does async decoding
the game provides buffers to the decoder thread which seems to decode the frame
with ESI as source and EDI as destination while the game thread waits for the
frame
--- quote ---

"Driver: San Francisco" uses Bink engine 1.99d

--- snip ---
 Base=10000000
 Size=0004A000 (303104.)
 Entry=10002240 binkw32.<ModuleEntryPoint>
 Name=binkw32
 File version=1.99d
 Path=C:\Program Files\Ubisoft\Driver San Francisco\binkw32.dll
--- snip ---

BINK changelog (just for reference): http://www.radgametools.com/bnkhist.htm

Renaming the directory containing the movies also works around:

--- snip ---
"C:\Program Files\Ubisoft\Driver San Francisco\Common\fmv"
--- snip ---

All videos can be properly played back with "Rad Video Tools".
The tools are statically linked with BINK (never ship with binkw32 dll).
Tested with 1.99n, 1.994e, 1.995c.

---

"Prototype" uses Bink engine 1.9h

--- snip ---
 Base=18000000
 Size=00037000 (225280.)
 Entry=180024F0 binkw32.<ModuleEntryPoint>
 Name=binkw32
 File version=1.9h
 Path=C:\Program Files\Prototype\binkw32.dll
--- snip ---

Unfortunately that game behaves even more randomly, with +relay "workaround"
not helping every time (heap corruption seems to be also involved here =
multiple bugs?).

Regards