[Bug 45457] Irfanview 4.x crashes after ALT key press

https://bugs.winehq.org/show_bug.cgi?id=45457

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |user32
                 CC|                            |[e-mail]
     Ever confirmed|0                           |1
           Keywords|                            |download
            Product|Wine-staging                |Wine
                URL|                            |http://www.irfanview.info/f
                   |                            |iles/iview451_x64.zip
    Regression SHA1|                            |387ba1d605b60499d1e173f9316
                   |                            |7397ce84da685
            Summary|Irfanview crashes after ALT |Irfanview 4.x crashes after
                   |key press                   |ALT key press
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Anastasius Focht  ---
Hello folks,

confirming. Please always try to report with vanilla Wine first.

--- snip ---
$ WINEDEBUG=+seh,+relay,+win,+msg,+menu wine ./i_view32.exe >>log.txt 2>&1
...
002e:Call user32.GetMessageW(0033f9b4,00000000,00000000,00000000) ret=0048d448
002e:Call
winex11.drv.MsgWaitForMultipleObjectsEx(00000001,0033f8f8,ffffffff,000004ff,00000000)
ret=7e8e054e
002e:Ret  winex11.drv.MsgWaitForMultipleObjectsEx() retval=00000000
ret=7e8e054e
002e:trace:msg:peek_message got type 7 msg 105 (WM_SYSKEYUP) hwnd 0x10076 wp a4
lp c0380001
002e:Ret  user32.GetMessageW() retval=00000001 ret=0048d448
002e:Call user32.TranslateAcceleratorW(00010076,000100e0,0033f9b4) ret=0048d429
002e:Ret  user32.TranslateAcceleratorW() retval=00000000 ret=0048d429
002e:Call user32.TranslateMessage(0033f9b4) ret=0048d434
002e:Ret  user32.TranslateMessage() retval=00000001 ret=0048d434
002e:Call user32.DispatchMessageW(0033f9b4) ret=0048d43b
002e:Call window proc 0x47fbc0
(hwnd=0x10076,msg=WM_SYSKEYUP,wp=00000012,lp=c0380001)
002e:Call user32.GetMenu(00010076) ret=004806d4
002e:trace:menu:GetMenu for 0x10076 returning 0x1007c
002e:Ret  user32.GetMenu() retval=0001007c ret=004806d4
002e:Call user32.GetMenuState(0001007c,00000000,00000400) ret=004806ec
002e:trace:menu:GetMenuState (menu=0x1007c, id=0000, flags=0400);
002e:trace:menu:do_debug_print_menuitem   item:  { ID=0x1007e, Sub=0x1007e,
fType=pop, Text=L"&File" } 
002e:Ret  user32.GetMenuState() retval=00001f10 ret=004806ec
002e:Call user32.HiliteMenuItem(00010076,0001007c,00000000,00000400)
ret=00480706
002e:trace:menu:HiliteMenuItem (0x10076, 0x1007c, 0000, 0400);
002e:trace:menu:MENU_HideSubPopups owner=0x10076 hmenu=0x1007c 0x0000
002e:trace:menu:MENU_SelectItem owner=0x10076 menu=0x1007c index=0x0000
select=0x0001
002e:trace:win:GetDCEx hwnd 0x10076, hrgnClip (nil), flags 00000003
002e:trace:win:GetDCEx found valid 0x2c0049 hwnd 0x10076, flags 00000013
002e:Call
winex11.drv.GetDC(002c0049,00010076,00010076,00338aa8,00338a98,00000013)
ret=7e8b0727
002e:Ret  winex11.drv.GetDC() retval=00000001 ret=7e8b0727
002e:trace:win:GetDCEx (0x10076,(nil),0x13): returning 0x2c0049 (updated)
002e:trace:menu:do_debug_print_menuitem MENU_DrawMenuItem:  { ID=0x1007e,
Sub=0x1007e, fType=pop, State=hi, Text=L"&File" } 
002e:trace:menu:MENU_DrawMenuItem rect=(0,1)-(31,19)
002e:Call winex11.drv.SystemParametersInfo(00001022,00000000,00338acc,00000000)
ret=7e8bf529
002e:Ret  winex11.drv.SystemParametersInfo() retval=00000000 ret=7e8bf529
002e:Call user32.GetDpiForSystem() ret=7e76b991
002e:Ret  user32.GetDpiForSystem() retval=00000060 ret=7e76b991
002e:Call user32.GetDpiForSystem() ret=7e76b991
002e:Ret  user32.GetDpiForSystem() retval=00000060 ret=7e76b991
002e:Call user32.GetDpiForSystem() ret=7e76b991
002e:Ret  user32.GetDpiForSystem() retval=00000060 ret=7e76b991
002e:Call user32.GetDpiForSystem() ret=7e76b991
002e:Ret  user32.GetDpiForSystem() retval=00000060 ret=7e76b991
002e:err:graphics:USER_CheckNotLock BUG: holding USER lock
002e:trace:seh:raise_exception code=80000003 flags=0 addr=0x7b443018
ip=7b443019 tid=002e
002e:trace:seh:raise_exception  info[0]=00000000
002e:trace:seh:raise_exception  eax=7e84a049 ebx=0001007c ecx=00000000
edx=7bd0d548 esi=00000001 edi=00338c20
002e:trace:seh:raise_exception  ebp=00338798 esp=0033877c cs=0023 ds=002b
es=002b fs=0063 gs=006b flags=00000202
002e:trace:seh:call_stack_handlers calling handler at 0x4c85f0 code=80000003
flags=0
002e:Call KERNEL32.GetLastError() ret=004cb050
002e:Ret  KERNEL32.GetLastError() retval=00000000 ret=004cb050
002e:Call KERNEL32.UnhandledExceptionFilter(00338280) ret=004cb3af
wine: Unhandled exception 0x80000003 in thread 2e at address 0x7b443018 (thread
002e), starting debugger... 
--- snip ---

--- snip ---
387ba1d605b60499d1e173f93167397ce84da685 is the first bad commit
commit 387ba1d605b60499d1e173f93167397ce84da685
Author: Nikolay Sivov 
Date:   Wed May 9 15:50:48 2018 +0300

user32/menu: Return locked menu data when looking for menu items.

Signed-off-by: Nikolay Sivov 
    Signed-off-by: Huw Davies 
    Signed-off-by: Alexandre Julliard

:040000 040000 36218481dbd8bb91255d93a814a013d94dacd3ca
05873edc3ddc8eaa4002afc3cf48196a81c14786 M    dlls
--- snip ---

https://source.winehq.org/git/wine.git/commitdiff/387ba1d605b60499d1e173f931...

$ sha1sum iview451*
3b0a8628afa99849fdcf2f79fb9c36fd40c24cec  iview451_x64.zip
2816891e4ec29ac96edb22cdf2db9b344368cc65  iview451.zip

$ du -sh iview451*
3.0M    iview451_x64.zip
2.2M    iview451.zip

$ wine --version
wine-3.12-110-g414fe80aeb

Regards