[Bug 40854] Adobe Flash Player 22-25 installer crashes (wtsapi32.WTSQuerySessionInformation needs to support WTSUserName info class)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=40854

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |a389b33c25ca93a8a265ae6dd07
                   |                            |9e002bf4ea27c
         Resolution|INVALID                     |FIXED
                 CC|                            |[e-mail]
                URL|                            |https://web.archive.org/web
                   |                            |/20170331232653/https://fpd
                   |                            |ownload.adobe.com/get/flash
                   |                            |player/latest/help/install_
                   |                            |flash_player_ppapi.exe
            Summary|Flash Player 22 crashes     |Adobe Flash Player 22-25
                   |when it is installed        |installer crashes
                   |                            |(wtsapi32.WTSQuerySessionIn
                   |                            |formation needs to support
                   |                            |WTSUserName info class)
          Component|-unknown                    |wtsapi32
           Keywords|                            |download, Installer

--- Comment #3 from Anastasius Focht  ---
Hello folks,

confirming with old Wine 1.6.2 release.

It was fixed by commit
https://source.winehq.org/git/wine.git/commitdiff/a389b33c25ca93a8a265ae6dd0...
("wtsapi32: Improve the stub for WTSQuerySessionInformationW.")

Part of Wine 3.6 release.

Thanks Hans.

Before fix:

--- snip ---
...
0009:Call KERNEL32.GetProcAddress(7c410000,00437cdc "WTSFreeMemory")
ret=004102a9
0009:Ret  KERNEL32.GetProcAddress() retval=7c4190b0 ret=004102a9
0009:Call KERNEL32.GetProcAddress(7c410000,00437cc0
"WTSQuerySessionInformationW") ret=004102a9
0009:Ret  KERNEL32.GetProcAddress() retval=7c419128 ret=004102a9
0009:Call KERNEL32.GetProcAddress(7c410000,00437ca4
"WTSQuerySessionInformationA") ret=004102a9
0009:Ret  KERNEL32.GetProcAddress() retval=7c419110 ret=004102a9
0009:Call KERNEL32.GetProcAddress(7c410000,00437c8c "WTSEnumerateSessionsA")
ret=004102a9
0009:Ret  KERNEL32.GetProcAddress() retval=7c419080 ret=004102a9
0009:Call
wtsapi32.WTSEnumerateSessionsA(00000000,00000000,00000001,0033ec6c,0033ec80)
ret=00414424
0009:fixme:wtsapi:WTSEnumerateSessionsA Stub (nil) 0x00000000 0x00000001
0x33ec6c 0x33ec80
0009:Ret  wtsapi32.WTSEnumerateSessionsA() retval=00000001 ret=00414424
0009:Call ntdll.RtlAllocateHeap(017b0000,00000000,00000010) ret=0041fe27
0009:Ret  ntdll.RtlAllocateHeap() retval=017bed80 ret=0041fe27
0009:Call ntdll.RtlAllocateHeap(017b0000,00000000,00000010) ret=0041fe27
0009:Ret  ntdll.RtlAllocateHeap() retval=017bf560 ret=0041fe27
0009:Call
wtsapi32.WTSQuerySessionInformationW(00000000,00000000,00000005,0033ec7c,0033ec50)
ret=00414562
0009:fixme:wtsapi:WTSQuerySessionInformationW Stub (nil) 0x00000000 5 0x33ec7c
0x33ec50
0009:Ret  wtsapi32.WTSQuerySessionInformationW() retval=00000000 ret=00414562
0009:Call KERNEL32.GetLastError() ret=00414564
0009:Ret  KERNEL32.GetLastError() retval=00000000 ret=00414564
0009:trace:seh:raise_exception code=c0000005 flags=0 addr=0x41ec88 ip=0041ec88
tid=0009
0009:trace:seh:raise_exception  info[0]=00000000
0009:trace:seh:raise_exception  info[1]=00000000
0009:trace:seh:raise_exception  eax=00000000 ebx=7b424fb8 ecx=0040f884
edx=7bcf9de0 esi=017be7d8 edi=00000000
0009:trace:seh:raise_exception  ebp=0033ec34 esp=0033ec34 cs=0023 ds=002b
es=002b fs=0063 gs=006b flags=00010246
0009:trace:seh:call_stack_handlers calling handler at 0x434a9b code=c0000005
flags=0 
--- snip ---

After fix:

--- snip ---
...
0009:Call KERNEL32.GetProcAddress(7c180000,00437cdc "WTSFreeMemory")
ret=004102a9
0009:Ret  KERNEL32.GetProcAddress() retval=7c1880b0 ret=004102a9
0009:Call KERNEL32.GetProcAddress(7c180000,00437cc0
"WTSQuerySessionInformationW") ret=004102a9
0009:Ret  KERNEL32.GetProcAddress() retval=7c188128 ret=004102a9
0009:Call KERNEL32.GetProcAddress(7c180000,00437ca4
"WTSQuerySessionInformationA") ret=004102a9
0009:Ret  KERNEL32.GetProcAddress() retval=7c188110 ret=004102a9
0009:Call KERNEL32.GetProcAddress(7c180000,00437c8c "WTSEnumerateSessionsA")
ret=004102a9
0009:Ret  KERNEL32.GetProcAddress() retval=7c188080 ret=004102a9
0009:Call
wtsapi32.WTSEnumerateSessionsA(00000000,00000000,00000001,0033ec6c,0033ec80)
ret=00414424
0009:fixme:wtsapi:WTSEnumerateSessionsA Stub (nil) 0x00000000 0x00000001
0x33ec6c 0x33ec80
0009:Ret  wtsapi32.WTSEnumerateSessionsA() retval=00000001 ret=00414424
0009:Call ntdll.RtlAllocateHeap(017b0000,00000000,00000010) ret=0041fe27
0009:Ret  ntdll.RtlAllocateHeap() retval=017bed80 ret=0041fe27
0009:Call ntdll.RtlAllocateHeap(017b0000,00000000,00000010) ret=0041fe27
0009:Ret  ntdll.RtlAllocateHeap() retval=017bf560 ret=0041fe27
0009:Call
wtsapi32.WTSQuerySessionInformationW(00000000,00000000,00000005,0033ec7c,0033ec50)
ret=00414562
0009:fixme:wtsapi:WTSQuerySessionInformationW Stub (nil) 0x00000000 5 0x33ec7c
0x33ec50
0009:Call advapi32.GetUserNameW(00000000,0033ebbc) ret=7c188cfc
0009:Ret  advapi32.GetUserNameW() retval=00000000 ret=7c188cfc
0009:Call ntdll.RtlAllocateHeap(00110000,00000000,0000000c) ret=7c188d3d
0009:Ret  ntdll.RtlAllocateHeap() retval=0018f3f0 ret=7c188d3d
0009:Call advapi32.GetUserNameW(0018f3f0,0033ebbc) ret=7c188d4e
0009:Ret  advapi32.GetUserNameW() retval=00000001 ret=7c188d4e
0009:Ret  wtsapi32.WTSQuerySessionInformationW() retval=00000001 ret=00414562 
--- snip ---

$ sha1sum install_flash_player_ppapi.exe 
3139c6b289051f816f20d7ddf3b4be2f7fcddfb1  install_flash_player_ppapi.exe

$ du -sh install_flash_player_ppapi.exe 
20M    install_flash_player_ppapi.exe

Regards