[Bug 58442] New: x11 fullscreen retries mwm hints causing chaos

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58442

Bug ID: 58442
           Summary: x11 fullscreen retries mwm hints causing chaos
           Product: Wine
           Version: 10.8
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 78893
  --> http://bugs.winehq.org/attachment.cgi?id=78893
fix-fullscreen-toggle

somewhere after 10.8 e072358059abe8446e4ac9e89d2e0618629edf5f changed behavior
to keep trying to update window hints, even if they are non-changes(no-op)

https://gitlab.winehq.org/wine/wine/-/merge_requests/8079

on openbox, alt-tabbing watch_dogs will randomly toggle decor, then fullscreen
(i think this is a openbox bug or at least behavior) but at some point alt-tab
will go to nothing focused, then another alt-tab will focus the game. so if you
have 2 windows, it takes 3 alt-tabs to go between them.

on fluxbox/my-fork multi-alt-tabbing the fullscreen window will go between
expected fullscreen and using the decor size of the frame and then resize the
'not fullscreen' watch_dogs window inside, leaving with an empty border where
the titlebar and borders would be. (even with telling properties to not change
in the wm itself, wine tries to keep changing settings and this happens)

jwm is kind of fubar no matter what

jwm and fluxbox both still require QS_POSTMESSAGE fix to get past the
splashscreen : see https://bugs.winehq.org/show_bug.cgi?id=57954

not sure what the reason was behind the above change but it causes hints to be
repeatedly changed, which incorrectly detects 'fullscreen' by ...

dlls/win32u/window.c : apply_window_pos()

calls

dlls/win32u/sysparams.c : is_window_rect_full_screen()

checks rects sizes to determine fullscreen

(then calls x11drv)
user_driver->pWindowPosChanged()

which finally calls wm_net and wmw hint updates

fullscreen is incorrect because a minimized window does not keep its
size/monitor i assume. then the 'no-op' change retries and somewhere things get
set to random states, like wanting titlebars and decor again.

patch attached that lets it work on fluxbox and openbox, however, not sure that
is complete, as it crosses over with many other bugs since late 9.x

thinking the openbox issue may be related to a bug with
c67bfdbeba1860c891e53c64379f5e86d8e8b664