http://bugs.winehq.org/show_bug.cgi?id=14717
Andrew Eikum aeikum@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #37301|0 |1 is obsolete| | Attachment #37336|0 |1 is obsolete| |
--- Comment #220 from Andrew Eikum aeikum@codeweavers.com 2011-11-07 15:05:22 CST --- Created attachment 37368 --> http://bugs.winehq.org/attachment.cgi?id=37368 Alexander's split patchset, cleaned up for submission
I've taken Alexander's latest patchset and cleaned it up to about submission quality.
GyB: I tested the Still Life 2 demo that you linked with this patchset and it seemed to work completely fine.
I also tested Total Overdose and it worked fairly well, although there were audio syncing issues, some sound effects seemed trimmed, and it seemed like the background music looped. I wasn't able to get the demo running in VirtualBox due to DRM issues (in a demo???), so I can't verify if that behavior is different from Windows.
Alexander: The last patch in the series does quite a lot with bitshifting and masking. It's unclear what the purpose is. Is it possible to write the code more clearly, or to add comments explaining what DSOUND_FREQSHIFT and related struct members are used for?