https://bugs.winehq.org/show_bug.cgi?id=40191
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |dcf914857c1e29b64a31a67685b | |123a09db1bae1 Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #9 from Sebastian Lackner sebastian@fds-team.de --- (In reply to François Gouget from comment #8)
Final notes from my TestBot timeline:
- Configuring a QEMU VM to have 'two logical CPUs' results in a dual
processor machine by default. However regular versions of Windows (i.e. non-Pro / Enterprise) are restricted to only use a single CPU. They will start on multi-processor machines but make use of only one. This is not an issue for our Windows 7 VMs as Pro and Ultimate versions can use up to two processor. But our Windows 8 and 10 VMs use regular editions. So they need QEMU to be configured with a single multi-core processor instead to properly test 'SMP' configurations.
- On Windows 8+ the SpinCount value of the RtlInitializeCriticalSectionEx() tests in ntdll:rtl is different on a multi-core or hyperthreaded CPU than on a single single-core non-hyperthreaded one. On Window s7 SpinCount is 0 no matter what the processor configuration: multi-processor, multi-core or hyperthreading. So this is a Windows 8+ thing. On Windows 8 SpinCount may also take non-zero values on systems with multiple single-core non-hyperthreaded processors but we cannot test that configuration.
- I changed wtbw8 to use a single dual-core processor. wtbwvista, wtbw864
and wtbw1064 will need similar changes.
We do not necessarily have to adjust all VMs, I think its just good to test with a big variety of different systems, to catch test failures as early as possible.
Since http://source.winehq.org/git/wine.git/commit/dcf914857c1e29b64a31a67685b123a... the test failure should be gone, so marking this bug as FIXED.