[Bug 17437] ATI and EVE Premium: no models display / crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=17437

Florian Sievert  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

Willem Brosz  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]              |

rig0r  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]         |

Dan Merillat  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]        |

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #57 from Matthieu Bertin   2009-04-09 03:54:14 ---
how do you remove the compiled version of wine then ? before i compile it
again...

--- Comment #58 from Eddy Y.   2009-04-09 04:19:17 ---
(In reply to comment #57)
> how do you remove the compiled version of wine then ? before i compile it
> again...

You just overwrite the current version with the one you will be compiling.

First, patch your source code, making sure that you have the corresponding code
version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine
1.1.6).

Second, check where your existing wine is with 'whereis wine'.

If it's in /usr/bin, then use

$ ./configure --prefix=/usr

Otherwise, do

$ ./configure

Then,

$ make
$ sudo make install

--- Comment #59 from Matthieu Bertin   2009-04-09 17:47:25 ---
Here it is. I did what you said, and it still doesn't work.
I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers
available on synaptic.

here is a short version:

brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch 
patching file dlls/wined3d/baseshader.c
patching file dlls/wined3d/directx.c
patching file dlls/wined3d/wined3d_main.c
patching file dlls/wined3d/wined3d_private.h
Hunk #1 succeeded at 290 (offset -8 lines).
brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure 
(conf. trace)
brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make
(traces)
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install

i also tried with --prefix=/usr/local as it was the path shown by whereis wine.

--- Comment #60 from Eddy Y.   2009-04-10 03:13:49 ---
(In reply to comment #59)
> Here it is. I did what you said, and it still doesn't work.
> I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers
> available on synaptic.

I use the latest drivers from ATI. Could you try with that please? Also, do you
have the user.reg settings specified earlier in the thread?

See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
> brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
>
> i also tried with --prefix=/usr/local as it was the path shown by whereis wine.

I'm out of ideas.

What error are you getting? Does EVE not run at all? Or, does it run with
graphics glitches?

--- Comment #61 from Matthieu Bertin   2009-04-10 03:58:51 ---
(In reply to comment #60)
> (In reply to comment #59)
> > Here it is. I did what you said, and it still doesn't work.
> > I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers
> > available on synaptic.
>
> I use the latest drivers from ATI. Could you try with that please? Also, do you
> have the user.reg settings specified earlier in the thread?
>
> See http://bugs.winehq.org/show_bug.cgi?id=17437#c23

IT JUST DID THE TRICK ! Thanks a lot.

everything works fine now !

--- Comment #62 from Florian Sievert   2009-04-10 15:27:01 ---
> IT JUST DID THE TRICK ! Thanks a lot.

I can confirm this. I tried for some days now to get the patch for my ati card.
However, everything seems to fail. Adding the options to the user.reg and the
patch seems to work fine for ati users. Thanks!

--- Comment #63 from Connor   2009-04-12 18:11:29 ---
We need a new patch for wine 1.1.19.

Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.

Patched wine compiles, but too much has changed and models are gone again.

Cmd-line shows:

fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION
(0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>>
GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573

--- Comment #64 from Mathieu Belanger   2009-04-12 22:12:13 ---
Created an attachment (id=20410)
 --> (http://bugs.winehq.org/attachment.cgi?id=20410)
Wine 1.1.19 patch for Apocrypha

Here the new patch for Wine 1.1.19!

Enjoy!

--- Comment #65 from Mathieu Belanger   2009-04-12 22:14:14 ---
Created an attachment (id=20411)
 --> (http://bugs.winehq.org/attachment.cgi?id=20411)
Wine 1.1.19 patch for Apocrypha

Here the new patch for Wine 1.1.19!

Enjoy!

--- Comment #66 from Mathieu Belanger   2009-04-12 22:16:22 ---
Created an attachment (id=20412)
 --> (http://bugs.winehq.org/attachment.cgi?id=20412)
Wine 1.1.19 patch for Apocrypha

Here the new patch for Wine 1.1.19!

Enjoy!

--- Comment #67 from Mathieu Belanger   2009-04-12 22:17:41 ---
Sorry for the triple post, got a Time out error from winehq....

--- Comment #68 from A.T.   2009-04-13 14:06:02 ---
author  Stefan Dösinger

Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)

committer       Alexandre Julliard

Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)

commit  754b5cf2adc73a917d7d60c35d5cad5897a5e92d

tree    fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe        tree | snapshot

parent  0af0bafd6ae40f9832d9c630c24a6696ac284631        commit | diff

wined3d: Deal with reserved shader constants in the backend.

This moves the GLSL and ARB specific reserved constants out of directx.c into

the get_caps methods of the shader backends. That way the number of reserved

constants remains in the backend.

GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as

advertised by GL instead of some mixture of GL info and backend implementation

specifics. This makes it easier for backends to decide how many constants to

use.

===========================================================

from what i understand this is the (partial) patch already integrated by Stefan
in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post
results for 7600GT);

the only things missing seems to be the registry keys to force correct values
for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta
reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4
for M$ WIN was released few days ago, so linux 9.4 final seems to be just
around the corner)

--- Comment #69 from H. Verbeet   2009-04-13 14:25:18 ---
(In reply to comment #68)
> from what i understand this is the (partial) patch already integrated by Stefan
> in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post
> results for 7600GT);

No, it's related, but doesn't solve this issue yet. You need
http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for
fglrx) the following patches for that. Those still need some work though.

--- Comment #70 from Mathieu Belanger   2009-04-13 15:03:06 ---
This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card
and Nvidia 7xxx-

- The ATI Drivers are still buggy and still need overide via registery key for
uniform and varying.

- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch
is still needed for that because the formula are the same : max_constantsF =
GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and
MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So
without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.

--- Comment #71 from hpestilence   2009-04-14 23:10:35 ---
I tested out the patches on the mailing list and the wine from git with my
HD4850 and here are the results:

Everything seems to render fine on medium and low shader settings, including
shadows and hdr.

On high shaders the title screen was black with hdr and bloom on, turning those
off gave me a normal title screen. When I logged on in the game the station /
models didn't render regardless if hdr or bloom was on or off.

Looking through my logs it seems it's related to the original ati varyings bug
which is easily worked around by hardcoding a lower varying number. Only a
problem if you want to run in high settings though. :)

If your a nvidia card owner everything should work for you guys "out of the
box" if these patches get accepted.

--- Comment #72 from hpestilence   2009-04-22 01:53:28 ---
Created an attachment (id=20605)
 --> (http://bugs.winehq.org/attachment.cgi?id=20605)
shader error from wine git

I found a few models that didn't render specifically the covetor (possibly
other mining ships) and the dreadnoughts. I found the error and it seems a
shader uses 246 uniforms and only 245 is defined.

This is with the current wine in the git and just a little patch to lower my
varyings to 52.

--- Comment #73 from Vitaliy Margolen   2009-04-26 02:00:26 ---
*** Bug 18217 has been marked as a duplicate of this bug. ***