http://bugs.winehq.org/show_bug.cgi?id=30005
Bug #: 30005 Summary: Acrobat 8: installer action text for INSTALLMESSAGE_ACTIONDATA is not deformated Product: Wine Version: 1.4-rc5 Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: msi AssignedTo: wine-bugs@winehq.org ReportedBy: focht@gmx.net Classification: Unclassified
Hello,
while testing for bug 18231 I noticed the action text for INSTALLMESSAGE_ACTIONDATA was not deformated which results in meaningless installer display:
--- snip --- 0026:trace:msi:MSI_FormatRecordW (L"[RemoveFilesActionText]") ... 0026:trace:msi:msi_get_property returning (null) for property L"RemoveFilesActionText" ... 0026:trace:msi:msi_get_property returning L"File: [1]\r\n\r\nFolder: [9]" for property L"RemoveFilesActionText" ... 0026:trace:msi:MSI_ProcessMessage (nil) (nil) (nil) 0 200 L"File: [1]\r\n\r\nFolder: [9]" ... 0026:Call user32.SetWindowTextW(000400c2,01d0bac8 L"File: [1]\r\n\r\nFolder: [9]") ret=7ecd0a94 --- snip ---
Dumping "ActionText" table with "Orca":
--- snip --- RemoveFiles Removing files [RemoveFilesActionText] --- snip ---
Dumping "Property" table:
--- snip --- RemoveFilesActionText File: [1]
Folder: [9] --- snip ---
The msi source flags this problem indeed as "fixme":
http://source.winehq.org/git/wine.git/blob/b00e7039c5fcaa613b9776a38fe60bb69...
--- snip --- 1750 INT MSI_ProcessMessage( MSIPACKAGE *package, INSTALLMESSAGE eMessageType, MSIRECORD *record ) 1751 { ... 1894 switch (eMessageType & 0xff000000) 1895 { 1896 case INSTALLMESSAGE_ACTIONDATA: 1897 /* FIXME: format record here instead of in ui_actiondata to get the 1898 * correct action data for external scripts */ 1899 ControlEvent_FireSubscribedEvent(package, szActionData, record); 1900 break; 1901 case INSTALLMESSAGE_ACTIONSTART: 1902 { 1903 MSIRECORD *uirow; 1904 LPWSTR deformated; 1905 LPCWSTR action_text = MSI_RecordGetString(record, 2); 1906 1907 deformat_string(package, action_text, &deformated); 1908 uirow = MSI_CreateRecord(1); 1909 MSI_RecordSetStringW(uirow, 1, deformated); 1910 TRACE("INSTALLMESSAGE_ACTIONSTART: %s\n", debugstr_w(deformated)); 1911 msi_free(deformated); 1912 1913 ControlEvent_FireSubscribedEvent(package, szActionText, uirow); 1914 1915 msiobj_release(&uirow->hdr); 1916 break; 1917 } 1918 case INSTALLMESSAGE_PROGRESS: 1919 ControlEvent_FireSubscribedEvent(package, szSetProgress, record); 1920 break; 1921 } 1922 1923 return ERROR_SUCCESS; 1924 } --- snip ---
Regards