http://bugs.winehq.org/show_bug.cgi?id=14717
--- Comment #81 from Alexander E. Patrakov patrakov@gmail.com 2010-12-27 04:08:37 CST --- Thanks for explaining the apparent contradiction.
So our disagreements about the patch are:
1) too-aggressive defaults - I have to test Windows behaviour to decide. And yes, I have read flame wars caused by PulseAudio's default resampler, so I fully understand your desire to keep resource utilization to a minimum by default.
2) 24-bit and 32-bit support - can't test, but can read the code. Anyway, as I said, this is not a regression if reading and writing 24-bit values is done correctly, as the old code attempted to handle this situation, too. If this is indeed dead code, it can be dropped at any time. Will read some more code to form a more informed decision.
3) Bugs (such as already-found bug about wrong volume of mono streams). They just have to be found and fixed :)
Did I miss anything?