[Bug 33770] Strong Bad's Cool Game for Attractive People Demo has interesting rendering glitches on initial menu screen without native d3dx_36 (purist)

http://bugs.winehq.org/show_bug.cgi?id=33770

--- Comment #7 from Christian Costa  2013-07-06 10:08:39 CDT ---
Created attachment 45122
  --> http://bugs.winehq.org/attachment.cgi?id=45122
Don't return warnings on success

The vertex problem issue comes from the fact that even if the call succeeds,
the game interprets a non null error_messages pointer as an error.

By calling D3DCompile we use a newer version of the compiler which is more
strict and generates the following warning.
  - warning X3206: 'dot': implicit truncation of vector type
  - warning X3206: implicit truncation of vector type
  - warning X3206: 'mul': implicit truncation of vector type
D3DCompileShader does not generate such warnings.

I did a search and found something that comfirm this:

New Warning X3206: Implicit Truncation of Vector Type
Beginning in the August 2009 release of the DirectX SDK, the compiler will warn
when an implicit truncation of a vector type occurs.

It does not seem there is a way to disable this warning so we will have to
strip these strings in D3DCompileShader and reset the error messages pointer if
the resulting buffer is empty.

I will update the patch accordingly.