https://bugs.winehq.org/show_bug.cgi?id=50148
Bug ID: 50148 Summary: Microsoft Flight Simulator X Service Pack 1 installer page faults on PatchFiles (suggested patch) Product: Wine Version: 5.21 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: msi Assignee: wine-bugs@winehq.org Reporter: czbd@o2.pl Distribution: ---
Created attachment 68653 --> https://bugs.winehq.org/attachment.cgi?id=68653 Suggested patch
During the installation of Service Pack 1 for FSX (fsx_sp1_PLK.exe obtained from https://www.gry-online.pl/S030.asp?ID=15570, sha1sum 9a3af3b5daa6c7fe31accfa6d68e17ffb4ec3c12), a page fault happens in msi_cabextract(), called in ACTION_PatchFiles() (dlls/msi/files.c:829).
I have found this to occur because the installer package contains a patch that doesn't contain a cabinet at all, hence my suggested patch simply adds a check before msi_cabextract() is executed in that place.
With the patch included, the installation only fails because it's trying to install into a wrong directory (Flight Simulator X instead of Microsoft Flight Simulator X; simply need to install FSX in there in the first place or perhaps temporarily rename/symlink the directory), and, with that worked around, because the wine-provided mspatcha.dll doesn't support LZXD decompression, at which point providing a native DLL is enough to make the installation succeed.
I attach the suggested patch (well, of course (:), a log taken with an unpatched Wine 5.21-197-g86e6c0bc281, and one taken with the patch, but without native mspatcha.dll.