[Bug 25056] New: Worms Armageddon's "Fill" and "Random Holes" map editor tools produce interlaced images

http://bugs.winehq.org/show_bug.cgi?id=25056

Summary: Worms Armageddon's "Fill" and "Random Holes" map
                    editor tools produce interlaced images
           Product: Wine
           Version: 1.3.6
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: winex11.drv
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=31767)
 --> (http://bugs.winehq.org/attachment.cgi?id=31767)
winex11: Add X11DRV_PALETTE_GetColor function to resolve any COLORREF to an RGB

Using the "Fill" (paint bucket) and "Random holes" tools in the map editor
(both to erase and fill terrain) will cause the respective areas to be filled
with a vertically-interlaced pattern.

The pattern is actually a monochrome gray brush. Worms Armageddon passes
palette indices for white and black (PALETTEINDEX COLORREF values) to
CreateSolidBrush. BRUSH_SelectSolidBrush's check for monochrome surfaces
incorrectly compares the passed COLORREF to the RGB values of white and black,
and therefore considers the passed COLORREF (0x01000000 or 0x01000001) to be a
non-monochrome color.

Attached patches fix the problem by adding a function to convert any COLORREF
to an RGB COLORREF, and by making BRUSH_SelectSolidBrush use it.