[Bug 11789] New: Recent Fls API additions break many installers/apps

http://bugs.winehq.org/show_bug.cgi?id=11789

Summary: Recent Fls API additions break many installers/apps
           Product: Wine
           Version: CVS/GIT
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: ntdll
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Hello,

after upgrading to recent GIT (wine-0.9.56-264-g848383a) it seems the recent
Fls API additions broke almost every installer i'm working on ;-(

http://source.winehq.org/git/wine.git/?a=commit;h=6d6e9a42b13c827d1cc795c3b6...
http://source.winehq.org/git/wine.git/?a=commit;h=b2ad268a8b7d7ac65029bbdd71...

I won't question if there was a specific need to introduce this ...

Reason of crash in FlsAlloc() is simple.
Different TEB definition in <thread.h> vs. <winternl.h> leads to incorrect TEB
allocation size (ntdll -> thread.h) vs. usage (fiber/Fls -> winternl.h)

Solution: use winternl.h TEB definition to ensure correct TEB allocation size
in dlls/ntdll/thread.c
Either change include order of both (needs <stdarg.h>) .. or sync both .. or
better get rid of the thread.h one to avoid such recurring problem.

Regards