[Bug 58958] New: Inconsistent window surface updates and solution

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58958

Bug ID: 58958
           Summary: Inconsistent window surface updates and solution
           Product: Wine
           Version: 10.18
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winevulkan
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

I tried Affinity 3.0 by Canva on Linux using ElementalWarrior Wine (branch
affinity-photo3-wine9.13-part3). All is fine, no visual artifacts with AMD
graphics and setting two environment variables.

WINEDLLOVERRIDES="opencl="
DXVK_CONFIG="d3d9.deferSurfaceCreation = True; d3d9.shaderModel = 1"

There are visual artifacts using any other Wine. I tried 9.7, and many 10.x
releases including 10.17 and 10.18. The Affinity canvas may not appear unless I
hover the mouse over it changing personas or workspaces e.g. Vector, Pixel,
repeatedly.

I went through the affinity-photo3-wine9.13-part3 patch series and applied
three lines from it. That resolved the canvas occasionally not appearing.

Add fix for inconsistent window surface updates with Canva applications.

The lines can be found in ElementalWarrior's Wine repo,
branch affinity-photo3-wine9.13-part3.

Tested-by: Mario Roy <...>

diff -uarp a/dlls/win32u/vulkan.c wine-10.18/dlls/win32u/vulkan.c
--- a/dlls/win32u/vulkan.c
+++ b/dlls/win32u/vulkan.c
@@ -948,6 +948,9 @@ static VkResult win32u_vkCreateWin32SurfaceKHR
         return res;
     }

+    /* make sure the window has a pixel format selected to get consistent
window surface updates */
+    if (!get_window_pixel_format( create_info->hwnd, FALSE ))
set_window_pixel_format( create_info->hwnd, 1, TRUE );
+    
     vulkan_object_init( &surface->obj.obj, host_surface );
     surface->obj.instance = instance;
     instance->p_insert_object( instance, &surface->obj.obj );