http://bugs.winehq.org/show_bug.cgi?id=15367
Dylan Smith dylan.ah.smith@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dylan.ah.smith@gmail.com
--- Comment #10 from Dylan Smith dylan.ah.smith@gmail.com 2009-03-07 21:34:08 --- (In reply to comment #8)
for the sake of record, this is the fix http://www.winehq.org/pipermail/wine-patches/2008-September/062041.html not sure if it'll ever be committed
Did you ask why it wasn't accepted?
Perhaps it wasn't clear that you understood what was happening?
Specifically it is Globals.active_win->page that is NULL in this case.
What happens is that winhlp32.exe is executed, but no hlp file is specified on the command line, only the -x flag which hides winhlp32 and prevents GetFileOpenName from being called to get the hlp file to display. At this point no page has been open, so Globals.active_win->page is NULL.
Next the notepad process sends a WM_COPYDATA message to the winhlp32 process by calling WinHelpA. This is what causes MACRO_HelpOn to try to open "winhelp.hlp", however assumes Globals.active_win->page is not NULL, so it crashes.
All of this seems like normal behaviour, except MACRO_HelpOn should check if Globals.active_win->page is NULL.