https://bugs.winehq.org/show_bug.cgi?id=46996
--- Comment #1 from Andrew Eikum aeikum@codeweavers.com --- Hi Nikola!
In general, the patches look mostly OK. In one, you introduce tab characters where you should be using spaces. You should also split the dsound_convert.c changes into two separate patches. One revising the 5.1 downmix, and a different patch introducing the 7.1 downmix. When you are ready to submit, they should be sent as patch emails to wine-devel, see the information here https://wiki.winehq.org/Submitting_Patches We can continue revising the patches here until we are both happy with them.
I'm unsure about the changes to the downmix algorithm. What we should do is whatever Windows's dsound does. If PulseAudio's algorithm doesn't match Windows, we should figure out what Windows does instead of choosing a different algorithm found online. I'm especially concerned about dropping LFE.
If you have access to a Windows machine or VM, this should be easy to write a test (create a stereo primary buffer and a 7.1 secondary buffer and observe the output mix). Or, it's possible someone online has already analyzed the Windows dsound downmix algorithms.