[Bug 51312] New: dxgi:dxgi: Wrong screen mode order on AMD GPUs (cw-rx460)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51312

Bug ID: 51312
           Summary: dxgi:dxgi: Wrong screen mode order on AMD GPUs
                    (cw-rx460)
           Product: Wine
           Version: 6.10
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]

dxgi:dxgi gets failures of the form:

https://test.winehq.org/data/patterns.html#dxgi:dxgi

dxgi.c:1460: Test failed: Mode 3: Modes should have been sorted, refresh rate
59.940060 < 85.000000.
dxgi.c:1460: Test failed: Mode 22: Modes should have been sorted, refresh rate
59.940060 < 85.000000.
dxgi.c:1460: Test failed: Mode 55: Modes should have been sorted, refresh rate
59.940060 < 75.000000.

* These failures happen on all available Windows versions (8.1 to 10 2009).
* They also happen regardless of the Radeon driver version: 19.11.3 to 21.4.1.
* They don't happen on machines with any other GPU (cw-gtx560 and QEmu VMs).
* They also happen systematically so are not probably caused by a threading
issue.
* So this really looks like a Radeon-specific behavior.

The failing test was introduced by the following commit:

commit eb2028fa90c41d3b7b8b4f924cd86059c5ba1e0d
Author:     Andrew Eikum 
AuthorDate: Mon Oct 28 16:59:18 2019 +0330

dxgi: Sort reported output modes.

Sekiro: Shadows Die Twice depends on this for its mode switching.

Signed-off-by: Andrew Eikum 
    Signed-off-by: Henri Verbeet 
    Signed-off-by: Alexandre Julliard

Does the application crash on Windows machines with an AMD GPU?
Or does the Radeon driver return the wrong order only on some GPUs?
If the application does not crash maybe our order specification is a bit too
strict?

Given that an application depends on this we probably want Wine to respect the
ordering.
Just add a broken()?