http://bugs.winehq.org/show_bug.cgi?id=33391
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |
--- Comment #2 from Anastasius Focht focht@gmx.net 2013-04-15 18:09:30 CDT --- Hello Austin,
usually I don't mind when my bug reports get resolution "fixed" as I assume it was verified by the resolver. I rely on that and don't do retesting ... until curiosity kills me.
"verstr" buffer is still reused/overwritten (by "MsiNTProductType" property).
Example: WinVer = Win7
--- snip --- 0027:trace:msi:msi_get_property returning L"1" for property L"VersionNT64" ... 0027:trace:msi:msi_get_property returning L"7601" for property L"WindowsBuild" ... 0027:trace:msi:MSI_EvaluateConditionW 1 <- L"( ((VersionNT64 < 502) OR (VersionNT64 = 502 AND WindowsBuild < 3506)) )" --- snip ---
Debugger session:
---snip --- Wine-dbg>n 871 msi_set_property( package->db, szVersionNT, verstr, len ); Wine-dbg>info locals 0x00007f05656dc4a4 set_installer_properties+0x99b: (0075daf0) MSIPACKAGE* package=0xaac050 (parameter [RBP-1192]) WCHAR* ptr="\users\focht\Temp" (local [RBP-40]) OSVERSIONINFOEXW OSVersion={dwOSVersionInfoSize=0x11c, dwMajorVersion=0x6, dwMinorVersion=0x1, dwBuildNumber=0x1db1, dwPlatformId=0x2, szCSDVersion={0x53, 0x65, 0x72, 0x76, 0x69, 0x63, 0x65, 0x20, 0x50, 0x61, 0x63, 0x6b, 0x20, 0x31, 0, 0x75, 0, 0, 0xb233, 0x656b, 0x7f05, 0, 0xc000, 0xaa, 0, 0, 0x2, 0, 0, 0, 0x6990, 0xab, 0, 0, 0x5e98, 0xab, 0, 0, 0xd9d0, 0x75, 0, 0, 0x6990, 0xab, 0, 0, 0x4, 0x8000, 0, 0, 0, 0, 0, 0, 0xbb0e, 0x656d, 0x7f05, 0, 0, 0, 0, 0, 0xbb0d, 0x656d, 0x7f05, 0, 0, 0, 0, 0, 0x247, 0, 0x3dc, 0, 0xd23, 0, 0x1ce, 0, 0x258, 0, 0x7c, 0, 0x2ff6, 0, 0x236, 0, 0x286, 0, 0x285, 0, 0x283, 0, 0x282, 0, 0x1e86, 0, 0x2aeb, 0, 0x21c9, 0, 0x4d36, 0, 0xffff, 0xffff, 0xffff, 0xffff, 0xffff, 0xffff, 0xffff, 0xffff, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, wServicePackMajor=0x1, wServicePackMinor=0, wSuiteMask=0, wProductType=1, wReserved=0} (local [RBP-432]) ... WCHAR --none--[11] verstr={0x36, 0x30, 0x31, 0, 0x3118, 0, 0x595, 0, 0x247, 0, 0x3dc} (local [RBP-1056]) ... Wine-dbg>n 872 len = sprintfW( verstr, szFormat,OSVersion.wProductType ); Wine-dbg>n 873 msi_set_property( package->db, szMsiNTProductType, verstr, len ); Wine-dbg>p verstr {0x31, 0, 0x31, 0, 0x3118, 0, 0x595, 0, 0x247, 0, 0x3dc} ---snip ---
Regards