[Bug 21013] New: CHM viewer/MSHMTL gecko wrapper needs more work

http://bugs.winehq.org/show_bug.cgi?id=21013

Summary: CHM viewer/MSHMTL gecko wrapper needs more work
           Product: Wine
           Version: 1.1.34
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: mshtml
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=25204)
 --> (http://bugs.winehq.org/attachment.cgi?id=25204)
wordpad.tar.gz: wordpad.chm, Wine appearance, native appearance

Many CHM files aren't shown when open in wine's chm viewer, like e.g. wordpad's
help file.

[Bug 21013] ADMIN PLEASE DELETE

http://bugs.winehq.org/show_bug.cgi?id=21013

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID
            Summary|CHM viewer/MSHMTL gecko     |ADMIN PLEASE DELETE
                   |wrapper needs more work     |

--- Comment #1 from Vitaliy Margolen   2009-12-14 08:46:08 ---
And who gave you the right to distribute wordpad.chm? DO NOT attach files you
can not distribute!

[Bug 21013] ADMIN PLEASE DELETE

http://bugs.winehq.org/show_bug.cgi?id=21013

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Vitaliy Margolen   2009-12-14 08:46:17 ---
Closing

[Bug 21013] ADMIN PLEASE DELETE

http://bugs.winehq.org/show_bug.cgi?id=21013

--- Comment #3 from Alexandre Julliard   2009-12-14 08:59:44 ---
The content of attachment 25204 has been deleted by
    Alexandre Julliard 
who provided the following reason:

File is not redistributable

The token used to delete this attachment was generated at 2009-12-14 08:59:21.

[Bug 21013] ADMIN PLEASE DELETE

http://bugs.winehq.org/show_bug.cgi?id=21013

--- Comment #4 from Artem S. Tashkinov   2009-12-14 11:34:20 ---
I'm terribly sorry, I couldn't imagine help files are a
copyright/DMCA/EULA/whatever subject.

I promise I'll never do anything like that in the future.

Again, I'm sorry.

[Bug 21013] ADMIN PLEASE DELETE

http://bugs.winehq.org/show_bug.cgi?id=21013

--- Comment #5 from Artem S. Tashkinov   2009-12-14 12:40:29 ---
There's one thing that has just crossed my mind.

You can legally obtain this file (and many other CHM files) by downloading a
trial version of:

1) Windows 2003 Server R2 SP2:

http://www.microsoft.com/windowsserver2003/r2/trial/installinstruct.mspx

or

2) windows 2008 R2 Server:

http://www.microsoft.com/windowsserver2008/en/us/trial-software.aspx

or

3) Windows 7 Enterprise Trial (live.com registration required):

http://technet.microsoft.com/en-us/evalcenter/cc442495.aspx

I'd be glad to reopen this bug report, if it's advisable.

[Bug 21013] CHM viewer/MSHMTL gecko wrapper needs more work

http://bugs.winehq.org/show_bug.cgi?id=21013

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |UNCONFIRMED
         Resolution|INVALID                     |
            Summary|ADMIN PLEASE DELETE         |CHM viewer/MSHMTL gecko
                   |                            |wrapper needs more work

--- Comment #6 from Vitaliy Margolen   2009-12-14 19:55:55 ---
Thanks Alexandre. Reopening.

(In reply to comment #5)
> You can legally obtain this file (and many other CHM files) by downloading a
> trial version of:

That still doesn't give you the legal right to redistribute whole or in part
that trial version. If ever in doubt - just don't attach anything that's not
yours - link it if you must.

[Bug 21013] CHM viewer/MSHMTL gecko wrapper needs more work

http://bugs.winehq.org/show_bug.cgi?id=21013

Jacek Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Jacek Caban  2011-03-17 07:41:06 CDT ---
Please retest with current Git (or the next release). The bug is probably
fixed.

[Bug 21013] CHM viewer/MSHMTL gecko wrapper needs more work

http://bugs.winehq.org/show_bug.cgi?id=21013

--- Comment #8 from Artem S. Tashkinov  2011-03-17 07:54:11 CDT ---
(In reply to comment #7)
> Please retest with current Git (or the next release). The bug is probably
> fixed.

I will test as soon as Wine 1.3.16 is out.

[Bug 21013] CHM viewer/MSHMTL gecko wrapper needs more work

http://bugs.winehq.org/show_bug.cgi?id=21013

--- Comment #9 from Artem S. Tashkinov  2011-03-18 16:10:20 CDT ---
OK, I'm now running Wine 1.3.16.

I can only see the first initial page of the WordPad's CHM help file: table of
contents is shown but if you click it nothing happens, so effectively you
cannot browse this help file (except when clicking items in "Index" or "Search"
- but that's far from being convenient or useful).

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

Artem S. Tashkinov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|CHM viewer/MSHMTL gecko     |Table of contents is
                   |wrapper needs more work     |unusable in Wine's CHM
                   |                            |viewer application

--- Comment #10 from Artem S. Tashkinov  2011-03-18 16:14:58 CDT ---
I'm not sure MSHTML is the right component, but there isn't one for CHM.

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

Jacek Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|mshtml                      |hhctrl.ocx

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

wineatic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from wineatic  2011-03-24 08:04:12 CDT ---
The file "wordpad.chm" is a special help file which contains links to the local
Windows file system. If you copy "wordpad.chm" to a network share, you wouldn't
be able to display/ browse the file in Windows, too.

You should not use .chm files that have been copied from an existing Windows
installation. Any other help file that belongs to the setup of a regular
Windows application should be fine for testing operations.

Well, if "wordpad.chm" is the only file you have problems with, we should close
this bug.

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

--- Comment #12 from Artem S. Tashkinov  2011-03-24 08:21:16 CDT ---
(In reply to comment #11)
> The file "wordpad.chm" is a special help file which contains links to the local
> Windows file system. If you copy "wordpad.chm" to a network share, you wouldn't
> be able to display/ browse the file in Windows, too.
>
> You should not use .chm files that have been copied from an existing Windows
> installation. Any other help file that belongs to the setup of a regular
> Windows application should be fine for testing operations.
>
> Well, if "wordpad.chm" is the only file you have problems with, we should close
> this bug.

Not meaning to undervalue your words, but I was using wordpad.chm after
extracting it straight from an ISO file (so it cannot load any external
documents). Besides as I mentioned earlier hh.exe _shows_ pages from this help
file when you browse Index or access them via Search facility.

KchmViewer from KDE4 shows this file perfectly albeit without embedded
pictures.

So, this bug is still valid.

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

nathan.n  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

--- Comment #13 from nathan.n  2011-11-09 01:53:02 CST ---
Created attachment 37395
  --> http://bugs.winehq.org/attachment.cgi?id=37395
The Master Genealogist help file (.CHM) on Wine 1.3.32 (Table of contents is
unusable)

Present in Wine 1.3.32

Also the Option Icon is not present (see next attachment from Win XP)

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

--- Comment #14 from nathan.n  2011-11-09 01:54:38 CST ---
Created attachment 37396
  --> http://bugs.winehq.org/attachment.cgi?id=37396
The Master Genealogist help file (.CHM) on Windows XP (Table of contents is
usable)

The Master Genealogist help file (.CHM) on Windows XP (Table of contents is
usable) Options Icon is shown

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

--- Comment #15 from Erich Hoover  2012-02-03 15:31:07 CST ---
Created attachment 38681
  --> http://bugs.winehq.org/attachment.cgi?id=38681
hhctrl.ocx: Fix searching for Index and TOC file.

Please try the attached patch.

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

Erich Hoover  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

--- Comment #16 from Erich Hoover  2012-02-12 16:08:53 CST ---
(In reply to comment #15)
> Created attachment 38681 [details]
> hhctrl.ocx: Fix searching for Index and TOC file.
>
> Please try the attached patch.

This should be fixed by commit 4c908dd8dae7092734be67514d3aec1c79096f9a.

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

--- Comment #17 from Artem S. Tashkinov  2012-02-12 16:34:37 CST ---
(In reply to comment #16)
> (In reply to comment #15)
> > Created attachment 38681 [details]
> > hhctrl.ocx: Fix searching for Index and TOC file.
> >
> > Please try the attached patch.
>
> This should be fixed by commit 4c908dd8dae7092734be67514d3aec1c79096f9a.

Nay, it's not fixed (I've just tested Wine 1.4-rc3 - I guess it includes this
patch).

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

--- Comment #18 from Erich Hoover  2012-02-12 17:13:24 CST ---
(In reply to comment #17)
> ...
> Nay, it's not fixed (I've just tested Wine 1.4-rc3 - I guess it includes this
> patch).

Well, I tested with The Master Genealogist - what program did you try?

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

--- Comment #19 from Artem S. Tashkinov  2012-02-12 17:18:25 CST ---
(In reply to comment #18)
> (In reply to comment #17)
> > ...
> > Nay, it's not fixed (I've just tested Wine 1.4-rc3 - I guess it includes this
> > patch).
>
> Well, I tested with The Master Genealogist - what program did you try?

wine start wordpad.chm (from Windows XP SP3 English distro).

You can get it here: http://ompldr.org/vY3NoOA

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

--- Comment #20 from Erich Hoover  2012-02-12 18:00:31 CST ---
(In reply to comment #19)
> ...
> wine start wordpad.chm (from Windows XP SP3 English distro).

It looks to me like the file opens but that the navigation in the table of
contents doesn't work, which seems to me like a different issue from what was
previously described.

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

Erich Hoover  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38681|0                           |1
        is obsolete|                            |

--- Comment #21 from Erich Hoover  2012-02-12 19:21:36 CST ---
Created attachment 38848
  --> http://bugs.winehq.org/attachment.cgi?id=38848
hhctrl.ocx: Fix parsing of some TOC topics that reference other files.

(In reply to comment #19)
> ...
> wine start wordpad.chm (from Windows XP SP3 English distro).

Please try the attached patch.

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

--- Comment #22 from Artem S. Tashkinov  2012-02-13 03:29:09 CST ---
(In reply to comment #21)
> Created attachment 38848 [details]
> hhctrl.ocx: Fix parsing of some TOC topics that reference other files.
>
> Please try the attached patch.

This patched partially fixed table of contents handling for wordpad.chm and so
as soon as it's merged this bug report can be closed.

The only problem remains is that the "Using the Help Viewer" part of this file
doesn't work - wordpad.chm references another CHM file (nthelp.chm in this
case), but it seems like help viewer cannot fetch and show its contents.

fixme:ieframe:ClOleCommandTarget_Exec Unimplemented cmdid 67 of group
{000214d1-0000-0000-c000-000000000046}
fixme:ieframe:ClOleCommandTarget_Exec Unimplemented cmdid 63 of group
{000214d1-0000-0000-c000-000000000046}
fixme:ieframe:ClientSite_GetContainer (0x16711c)->(0x33f9fc)
fixme:ieframe:ClOleCommandTarget_Exec Unimplemented cmdid 84 of group
{000214d1-0000-0000-c000-000000000046}
fixme:ieframe:DocObjectService_IsErrorUrl 0x1884f0
L"mk:@MSITStore:Z:\tmp\wordpad.chm::/nthelp_overview.htm" 0x33f508
fixme:ieframe:handle_navigation_error Navigate to error page
fixme:ieframe:DocObjectService_IsErrorUrl 0x1884f0
L"mk:@MSITStore:Z:\tmp\wordpad.chm::/nthelp_overview.htm" 0x33f9b8
fixme:ieframe:handle_navigation_error Navigate to error page
err:mshtml:on_stop_nsrequest RemoveRequest failed: 80004005
fixme:ieframe:ClOleCommandTarget_Exec Unimplemented cmdid 25
fixme:ieframe:ClOleCommandTarget_Exec Unimplemented cmdid 26
fixme:ieframe:ClOleCommandTarget_Exec Unimplemented cmdid 29
fixme:ieframe:DocHostUIHandler_GetDropTarget (0x16711c)
fixme:ieframe:ClOleCommandTarget_Exec Unimplemented cmdid 28

Should I file a new bug report concerning the aforementioned problem?

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

Artem S. Tashkinov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29879

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

Erich Hoover  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38848|0                           |1
        is obsolete|                            |

--- Comment #23 from Erich Hoover  2012-02-13 12:46:57 CST ---
Created attachment 38858
  --> http://bugs.winehq.org/attachment.cgi?id=38858
hhctrl.ocx: Fix parsing of some TOC topics that reference other [v2]

(In reply to comment #22)
> ...
> The only problem remains is that the "Using the Help Viewer" part of this file
> doesn't work - wordpad.chm references another CHM file (nthelp.chm in this
> case), but it seems like help viewer cannot fetch and show its contents.
> ...
> Should I file a new bug report concerning the aforementioned problem?

That's my bad, please try the revised patch (attached).

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

--- Comment #24 from Artem S. Tashkinov  2012-02-13 13:37:54 CST ---
(In reply to comment #23)
> That's my bad, please try the revised patch (attached).

Excellent! It now works perfectly - I hope Wine 1.4 will include this patch.

The only remaining problem is that nthelp.chm crashes wine, but that is bug
29879.

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

Artem S. Tashkinov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|29879                       |

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |98f0be8dc3d70cde04cf6e93c53
                   |                            |38775a66c24aa
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |FIXED

--- Comment #25 from Jerome Leclanche  2012-02-15 14:21:59 CST ---
Should be fixed by 98f0be8dc3d70cde04cf6e93c5338775a66c24aa.

[Bug 21013] Table of contents is unusable in Wine's CHM viewer application

http://bugs.winehq.org/show_bug.cgi?id=21013

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #26 from Alexandre Julliard  2012-02-17 13:51:24 CST ---
Closing bugs fixed in 1.4-rc4.