[Bug 36556] New: valgrind shows a definite leak in comctl32/tests/syslink.c

https://bugs.winehq.org/show_bug.cgi?id=36556

Bug ID: 36556
           Summary: valgrind shows a definite leak in
                    comctl32/tests/syslink.c
           Product: Wine
           Version: 1.7.19
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: normal
          Priority: P2
         Component: comctl32
          Assignee: [e-mail]
          Reporter: [e-mail]

../../../tools/runtest -q -P wine -T ../../.. -M comctl32.dll -p
comctl32_test.exe.so syslink && touch syslink.ok
preloader: Warning: failed to reserve range 00110000-68000000
preloader: Warning: failed to reserve range 7f000000-82000000
==26003== 120 bytes in 5 blocks are definitely lost in loss record 507 of 758
==26003==    at 0x7BC4C6DF: notify_alloc (heap.c:255)
==26003==    by 0x7BC50F23: RtlAllocateHeap (heap.c:1716)
==26003==    by 0x7B8457FF: HeapAlloc (heap.c:271)
==26003==    by 0x7B845A26: GlobalAlloc (heap.c:364)
==26003==    by 0x7B846E63: LocalAlloc (heap.c:967)
==26003==    by 0x4FE7A09: ReAlloc (comctl32undoc.c:101)
==26003==    by 0x504BDC5: SYSLINK_Render (syslink.c:749)
==26003==    by 0x504D69E: SysLinkWindowProc (syslink.c:1596)
==26003==    by 0x53B04F5: ??? (winproc.c:173)
==26003==    by 0x53B066A: call_window_proc (winproc.c:244)
==26003==    by 0x53B2803: WINPROC_call_window (winproc.c:900)
==26003==    by 0x536F11C: call_window_proc (message.c:2223)
==26003==    by 0x5371FBA: send_message (message.c:3260)
==26003==    by 0x53725D8: SendMessageW (message.c:3454)
==26003==    by 0x53A1E2B: WIN_CreateWindowEx (win.c:1634)
==26003==    by 0x53A2313: CreateWindowExW (win.c:1751)
==26003==    by 0x4D29DF0: create_syslink (syslink.c:174)
==26003==    by 0x4D2A03E: func_syslink (syslink.c:235)
==26003==    by 0x4D64DB9: run_test (test.h:584)
==26003==    by 0x4D651A8: main (test.h:654)
==26003==

[Bug 36556] valgrind shows a definite leak in comctl32/tests/syslink.c

https://bugs.winehq.org/show_bug.cgi?id=36556

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |valgrind

[Bug 36556] valgrind shows a definite leak in comctl32/tests/syslink.c

http://bugs.winehq.org/show_bug.cgi?id=36556

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Sebastian Lackner  ---
Created attachment 48856
  --> http://bugs.winehq.org/attachment.cgi?id=48856
comctl32: Fix memory leak in SYSLINK_FreeDocItem.

One more patch :) Does this fix the issue?

[Bug 36556] valgrind shows a definite leak in comctl32/tests/syslink.c

https://bugs.winehq.org/show_bug.cgi?id=36556

--- Comment #2 from Austin English  ---
(In reply to Sebastian Lackner from comment #1)
> Created attachment 48856 [details]
> comctl32: Fix memory leak in SYSLINK_FreeDocItem.
>
> One more patch :) Does this fix the issue?

I can't reproduce it currently on my laptop, with gcc-4.9.0 (both with/without
a virtual desktop).

I'll try it on another machine when I get a chance.

[Bug 36556] valgrind shows a definite leak in comctl32/tests/syslink.c

https://bugs.winehq.org/show_bug.cgi?id=36556

--- Comment #3 from Austin English  ---
I can't reproduce it on my laptop or desktop, currently, with gcc-4.9 or
gcc-4.8 :/

[Bug 36556] valgrind shows a definite leak in comctl32/tests/syslink.c

https://bugs.winehq.org/show_bug.cgi?id=36556

--- Comment #4 from Sebastian Lackner  ---
Hm, you haven't accidentially applied my patch already? ;) *joking*

I will try to reproduce it myself when I have setup my own Valgrind testing
environment. By looking at the code it should still be a leak, so I'm wondering
why its not detected anymore. Maybe valgrind gets confused by some other
problems in the same area (if there are any)?

[Bug 36556] valgrind shows a definite leak in comctl32/tests/syslink.c

https://bugs.winehq.org/show_bug.cgi?id=36556

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |f4640b04925e0044f6e32bb7d48
                   |                            |c85117052a599

--- Comment #5 from Nikolay Sivov  ---
Fixed with
http://source.winehq.org/git/wine.git/?a=commit;h=f4640b04925e0044f6e32bb7d4....

[Bug 36556] valgrind shows a definite leak in comctl32/tests/syslink.c

https://bugs.winehq.org/show_bug.cgi?id=36556

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.11.

[Bug 36556] valgrind shows a definite leak in comctl32/tests/syslink.c

https://bugs.winehq.org/show_bug.cgi?id=36556

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
   Target Milestone|---                         |1.8.x

[Bug 36556] valgrind shows a definite leak in comctl32/tests/syslink.c

https://bugs.winehq.org/show_bug.cgi?id=36556

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.8.x                       |---

--- Comment #7 from Michael Stefaniuc  ---
Removing 1.8.x milestone from bugs included in 1.8.4.