[Bug 54595] New: Split/Second crashes on launch due to missing HLSL_IR_RESOURCE_LOAD instruction type

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54595

Bug ID: 54595
           Summary: Split/Second crashes on launch due to missing
                    HLSL_IR_RESOURCE_LOAD instruction type
           Product: vkd3d
           Version: 1.6
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P2
         Component: hlsl
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

03c8:err:d3dcompiler:D3DCompile2 Shader log:
03c8:err:d3dcompiler:D3DCompile2     <anonymous>:1:436: E5017: Aborting due to
not yet implemented feature: Instruction type HLSL_IR_RESOURCE_LOAD.
03c8:err:d3dcompiler:D3DCompile2     <anonymous>:1:478: E5017: Aborting due to
not yet implemented feature: Instruction type HLSL_IR_RESOURCE_LOAD.
03c8:err:d3dcompiler:D3DCompile2     <anonymous>:1:520: E5017: Aborting due to
not yet implemented feature: Instruction type HLSL_IR_RESOURCE_LOAD.
03c8:err:d3dcompiler:D3DCompile2
03c8:err:d3dcompiler:D3DCompile2 Shader log:
03c8:err:d3dcompiler:D3DCompile2     <anonymous>:1:469: E5017: Aborting due to
not yet implemented feature: Instruction type HLSL_IR_RESOURCE_LOAD.
03c8:err:d3dcompiler:D3DCompile2     <anonymous>:1:511: E5017: Aborting due to
not yet implemented feature: Instruction type HLSL_IR_RESOURCE_LOAD.
03c8:err:d3dcompiler:D3DCompile2     <anonymous>:1:553: E5017: Aborting due to
not yet implemented feature: Instruction type HLSL_IR_RESOURCE_LOAD.
03c8:err:d3dcompiler:D3DCompile2     <anonymous>:1:594: E5017: Aborting due to
not yet implemented feature: Instruction type HLSL_IR_RESOURCE_LOAD.
03c8:err:d3dcompiler:D3DCompile2

1.6-171-gb1e13d6e

[Bug 54595] Split/Second crashes on launch (needs sm1 sample instructions)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54595

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Split/Second crashes on     |Split/Second crashes on
                   |launch due to missing       |launch (needs sm1 sample
                   |HLSL_IR_RESOURCE_LOAD       |instructions)
                   |instruction type            |
                 CC|                            |[e-mail]

[Bug 54595] Multiple games need SM1 sample instructions support (Split/Second, Death to Spies: Moment of Truth demo)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54595

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://files.aspyr.com/supp
                   |                            |ort/DTS_Demo_Installer.zip
            Summary|Split/Second crashes on     |Multiple games need SM1
                   |launch (needs sm1 sample    |sample instructions support
                   |instructions)               |(Split/Second, Death to
                   |                            |Spies: Moment of Truth
                   |                            |demo)

[Bug 54595] Multiple games need SM1 sample instructions support (Split/Second, Death to Spies: Moment of Truth demo, Cloning Clyde)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54595

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Multiple games need SM1     |Multiple games need SM1
                   |sample instructions support |sample instructions support
                   |(Split/Second, Death to     |(Split/Second, Death to
                   |Spies: Moment of Truth      |Spies: Moment of Truth
                   |demo)                       |demo, Cloning Clyde)

[Bug 54595] Multiple games need SM1 sample instructions support (Split/Second, Death to Spies: Moment of Truth demo, Cloning Clyde, Legend of Grimrock 2)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54595

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Multiple games need SM1     |Multiple games need SM1
                   |sample instructions support |sample instructions support
                   |(Split/Second, Death to     |(Split/Second, Death to
                   |Spies: Moment of Truth      |Spies: Moment of Truth
                   |demo, Cloning Clyde)        |demo, Cloning Clyde, Legend
                   |                            |of Grimrock 2)

[Bug 54595] Multiple games need SM1 sample instructions support (Split/Second, Death to Spies: Moment of Truth demo, Cloning Clyde, Legend of Grimrock 2)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54595

--- Comment #1 from Nikolay Sivov  ---
HLSL_IR_RESOURCE_LOAD is implemented in current vkd3d I believe.

Immediate failure for Death to Spies is different for me:

- tex2Dproj() - https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/219;
- clip() - https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/211;
- numeric array indexing with a variable (exact expression is
filterTaps[i*2+0]).

Current compiler also fails to resolve constant expression like this:

---
   static const int NUM_BLUR_TAPS=4;
   static const float4 filterTaps[NUM_BLUR_TAPS] =
---

I'll probably going to look at that next.

[Bug 54595] Multiple games need SM1 sample instructions support (Split/Second, Death to Spies: Moment of Truth demo, Cloning Clyde, Legend of Grimrock 2)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54595

--- Comment #2 from Nikolay Sivov  ---
The fix for array size expression is at
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/228.

[Bug 54595] Multiple games need SM1 sample instructions support (Split/Second, Death to Spies: Moment of Truth demo, Cloning Clyde, Legend of Grimrock 2)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54595

--- Comment #3 from Nikolay Sivov  ---
(In reply to Nikolay Sivov from comment #2)
> The fix for array size expression is at
> https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/228.

This is now merged
https://source.winehq.org/git/vkd3d.git/commit/d856be05196adc2dc83c5228acf2a....

[Bug 54595] Multiple games need SM1 sample instructions support (Split/Second, Death to Spies: Moment of Truth demo, Cloning Clyde, Legend of Grimrock 2)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54595

--- Comment #4 from Gijs Vermeulen  ---
It seems this one is fixed for me with wine-9.4-146-g552cc456d18 and current
vkd3d-git. The Split/Second demo only has some warnings related to HLSL
compilation, but runs fine otherwise. Cloning Clyde also doesn't show any
messages related to HLSL compilation anymore, unless +d3dcompiler is specified.

Andrey and/or Nikolay, can you confirm?

[Bug 54595] Multiple games need SM1 sample instructions support (Split/Second, Death to Spies: Moment of Truth demo, Cloning Clyde, Legend of Grimrock 2)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54595

--- Comment #5 from Nikolay Sivov  ---
I think it's fine to mark as fixed, once you tested enough of those. Following
bugs should be more targeted.

[Bug 54595] Multiple games need SM1 sample instructions support (Split/Second, Death to Spies: Moment of Truth demo, Cloning Clyde, Legend of Grimrock 2)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54595

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Gijs Vermeulen  ---
(In reply to Nikolay Sivov from comment #5)
> I think it's fine to mark as fixed, once you tested enough of those.
> Following bugs should be more targeted.

Thanks. In that case, marking FIXED.

[Bug 54595] Multiple games need SM1 sample instructions support (Split/Second, Death to Spies: Moment of Truth demo, Cloning Clyde, Legend of Grimrock 2)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54595

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Nikolay Sivov  ---
Closing bugs fixed in 1.13.